Fix CMake paths to support embedding via FetchContent/add_subdirectory - #404
Merged
Conversation
Replace CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR with CMAKE_CURRENT_SOURCE_DIR and CMAKE_CURRENT_BINARY_DIR in custom commands that reference source and output files within the libobjc2 project. This fixes build failures when libobjc2 is used as a subproject via FetchContent or add_subdirectory(), because those variables otherwise point to the parent project's root, causing "no such file" errors for block_trampolines.S, objc_msgSend.S, eh_trampoline.cc, and generated eh_trampoline.S. Affected files: - block_trampolines.obj custom command (Windows) - objc_msgSend.obj custom command (Windows) - eh_trampoline.S custom command (non-Windows, non-MinGW)
davidchisnall
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR with CMAKE_CURRENT_SOURCE_DIR and CMAKE_CURRENT_BINARY_DIR in custom commands that reference source and output files within the libobjc2 project.
This fixes build failures when libobjc2 is used as a subproject via FetchContent or add_subdirectory(), because those variables otherwise point to the parent project's root, causing "no such file" errors for block_trampolines.S, objc_msgSend.S, eh_trampoline.cc, and generated eh_trampoline.S.
Affected files: