iOS: Fix ignored orientation changes in embedded mode#119773
Open
abcjjy wants to merge 1 commit into
Open
Conversation
When running under the SwiftUI app lifecycle, the Godot view controller can be wrapped by a hosting controller that becomes the window's root view controller. In that case, orientation-related UIKit selectors must be propagated to the root controller before requesting an interface orientation update. This also fixes orientation settings not being applied correctly on iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
screen_set_orientationdoes not physically rotate screen (SwiftUI hosting controller issue) #118350Additional information
Fix orientation updates for embedded iOS builds.
Under the SwiftUI app lifecycle, the Godot view controller may be wrapped by a hosting controller that acts as the window's root view controller. Propagate orientation-related UIKit preferences to the root controller before requesting an update.
This also fixes orientation settings not being applied correctly on iOS.