Update custom_metadata per Issue 1292 - 8 - #1983
Merged
Merged
Conversation
Rendered page: Agent PR: #1306 Original Issue: #1292 -Polished the explanation of how and why custom_metadata works. It now clearly outlines how developers can pass service-specific configurations (like ttl and revision_ttl) directly to the underlying Agent Platform. - I found that the add_events_to_memory(events=...) section that the agent was proposing was already documented in the site.
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
joefernandez
left a comment
joefernandez
left a comment
Collaborator
There was a problem hiding this comment.
Please address comments, and let's review one more time.
Worked on feedback. Updated the custom metadata documentation to use a generic BaseMemoryService example instead of platform-specific services. The code snippet was also revised to use generic key-value pairs rather than prescriptive TTL keys.
Collaborator
Author
@joefernandez ready for another review! |
joefernandez
approved these changes
Jul 31, 2026
joefernandez
left a comment
joefernandez
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for updates! Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered page: https://deploy-preview-1983--adk-docs-preview.netlify.app/sessions/memory/
Agent PR: #1306
Original Issue: #1292
Code PR (Python): google/adk-python@59e8897
Corrections: Updated the custom metadata documentation to use a generic BaseMemoryService example instead of platform-specific services. The code snippet was also revised to use generic key-value pairs rather than prescriptive TTL keys.