docs(models): fix unparseable snippets and stale Claude setup steps - #2012
Open
GWeale wants to merge 2 commits into
Open
docs(models): fix unparseable snippets and stale Claude setup steps#2012GWeale wants to merge 2 commits into
GWeale wants to merge 2 commits into
Conversation
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrections to the
docs/agents/models/pages: two Python snippets that don't parse, a wrapper class name that doesn't exist, and setup steps that no longer match ADK 2.5.0.Changes
docs/agents/models/google-gemini.md— the Python snippet had unbalanced parentheses and would not parse; added the missing,and closing).docs/agents/models/google-gemma.md— the vLLM snippet was missing a comma afterextra_headers=auth_headers(syntax error); added it. Also added a note that Gemma 3 needsGemma(Gemini API) orGemma3Ollama(Ollama) fromgoogle.adk.models, since it has no native function calling or system instruction support.docs/agents/models/apigee.md— the wrapper was calledApigeeLLM; the class isApigeeLlm.docs/agents/models/agent-platform.md,docs/agents/models/anthropic.md— removed theLLMRegistry.register(Claude)setup step and its imports: the registry already routesclaude-3-*/claude-*-4*strings toClaude. Documented passingClaude(model=...)for identifiers outside those patterns, and corrected thethinking_levelnote — it raises a validation error onAnthropicGenerateContentConfigand is ignored with a warning on a plaintypes.GenerateContentConfig.docs/agents/models/litellm.md,docs/agents/models/agent-platform.md—pip install litellm→pip install "litellm>=1.84", the version ADK requires.docs/agents/models/litert-lm.md— thebase_urlexample omitted the scheme; nowhttp://localhost:8001.How this was produced
Part of a page-by-page audit of the Python docs against the
google/adk-pythonv2.5.0 source: every import resolved against a real 2.5.0 install, every constructor kwarg checked againstmodel_fields/inspect.signature, every documented default read off the field. A second independent pass re-derived each claim from source rather than trusting the finding, and a third conformed the new wording to the surrounding pages.mkdocs build --strictis clean.Only Python tabs and language-neutral prose were touched — this audit had no ground truth for the Go / Java / TypeScript SDKs.
Split out of a larger audit branch so each area can be reviewed on its own.