Consolidate cf_cc_{binary,library,test} implementations - #2983
Open
Databean wants to merge 1 commit into
Open
Conversation
This fixes the divergence that only `cf_cc_library` handled cases where both `srcs` and `hdrs` were empty, and makes the remaining divergences more explicit: - Only `cf_cc_binary` interacts with linkopts - Only `cf_cc_test` adds extra dependencies It may come up later that `deps` is configurable for `binary` and `library` (required for allocd) but cannot be configurable for `test` (so that cf_cc_library can add the additional links). Bug: b/543509210
Databean
force-pushed
the
consolidate_cc_target
branch
from
August 7, 2026 22:39
551a3e3 to
aa38d90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the divergence that only
cf_cc_libraryhandled cases where bothsrcsandhdrswere empty, and makes the remaining divergences more explicit:cf_cc_binaryinteracts with linkoptscf_cc_testadds extra dependenciesIt may come up later that
depsis configurable forbinaryandlibrary(required for allocd) but cannot be configurable fortest(so that cf_cc_library can add the additional links).Bug: b/543509210