proto: add TextDeltaContent and ThoughtSummaryDeltaContent (task 1 of #246)#281
Closed
joycel-github wants to merge 2 commits into
Closed
proto: add TextDeltaContent and ThoughtSummaryDeltaContent (task 1 of #246)#281joycel-github wants to merge 2 commits into
joycel-github wants to merge 2 commits into
Conversation
Introduce streaming delta content types modeled after the TextDelta and ThoughtSummaryDelta primitives in google-genai, and add text_delta / thought_summary_delta variants to the Content oneof (tags 27 and 28). These carry ordered, append-only chunks of the current contiguous text or thought-summary run so the antigravity harness can emit the first visible output as soon as the model stream produces it, without buffering entire text/thought blocks. Consumers accumulate adjacent deltas of the same role/kind for durable logs/history and flush on role change, kind change, non-delta output, or stream end. This is task 1 (Proto) from #246. Producer (harness), controller, and display wiring follow in subsequent PRs. Regenerated proto/content.pb.go via 'protoc --go_out=. --go_opt=paths=source_relative --go-grpc_out=. --go-grpc_opt=paths=source_relative proto/ax.proto proto/content.proto' using protoc v28.2 and protoc-gen-go v1.36.11 to match the existing generated code's toolchain.
- ThoughtSummaryDeltaContent is now a plain 'string text = 1' instead of a oneof; matches TextDeltaContent's shape and avoids premature abstraction (variants can be added later if needed). - Reorder the two delta messages to sit immediately before the Content message they extend, for readability. - Tighten doc comments.
Member
|
These fields are not Interactions Content compatible, am I right? We shouldn't introduce Content types that are not represented in Interactions. |
Collaborator
Author
|
we have decided to go with interaction proto and this issue will be postponed to milestone 3 when the proto is stable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 1 (Proto) of #246 — antigravity harness streaming support.
What
TextDeltaContentandThoughtSummaryDeltaContentmodeled after theTextDelta/ThoughtSummaryDeltastreaming primitives in google-genai.Follow-up PRs will be sent in sequence
More details see issue #246
text_delta/thought_summary_deltaas chunks arrive from the antigravity sdkinternal/controller/)text_deltaas streamed assistant text andthought_summary_deltaas streamed thought-summary text; add handling for the new delta types wherever content variants are switched on. Note that display is resonsible for identifying the boundary of different content and format accordingly (primary site:cmd/ax/internal/display.go).