Make TestApplication public.#5217
Merged
Merged
Conversation
A recent PR (10833) modifies Robolectric to use appComponentFactory to create the application class if available. Using a version of Robolectric with this PR included causes a hilt tests to fail, because their application class is not public. This CL resolves the issue by making application classes and their constructors public. PiperOrigin-RevId: 943373864
copybara-service
Bot
force-pushed
the
test_941206045
branch
from
e6295f2 to
22ca583
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make TestApplication public.
A recent PR (10833) modifies Robolectric to use appComponentFactory to
create the application class if available.
Using a version of Robolectric with this PR included causes a hilt tests to fail, because their application
class is not public.
This CL resolves the issue by making application classes and their constructors public.