Update QrCodeGenerator for PDF use#3781
Open
andreia-ferreira wants to merge 2 commits into
Open
Conversation
andreia-ferreira
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3781 +/- ##
============================================
+ Coverage 66.14% 66.33% +0.18%
Complexity 1660 1660
============================================
Files 386 387 +1
Lines 10039 10057 +18
Branches 1288 1290 +2
============================================
+ Hits 6640 6671 +31
+ Misses 2722 2709 -13
Partials 677 677
🚀 New features to boost your workflow:
|
shobhitagarwal1612
approved these changes
Jun 10, 2026
shobhitagarwal1612
left a comment
shobhitagarwal1612
left a comment
Member
There was a problem hiding this comment.
Looks great! Especially the test coverage!
| val qrBitmap by | ||
| produceState<ImageBitmap?>(initialValue = null, key1 = content, key2 = showLogo) { | ||
| value = withContext(Dispatchers.Default) { generateQrBitmap(content, showLogo) } | ||
| value = withContext(Dispatchers.Default) { encodeQrBitmap(content, showLogo) } |
Member
There was a problem hiding this comment.
nit: We can add the named argument useHighEcc to help with making the intent clearer.
| ): ImageBitmap = | ||
| if (logo == null || !fitsLogoCapacity(content)) { | ||
| encodeQrBitmap(content, useHighEcc = false) | ||
| } else encodeQrBitmap(content, useHighEcc = true).withCenteredLogo(logo, logoSizeFraction) |
Member
There was a problem hiding this comment.
nit: Please consider adding braces around the else branch for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3715
(Split from #3774)
This PR expands the
QrCodeGeneratorin order to provide a bitmap with a centered logo. This will be used to embed a QR code in PDF exports.The shared constants were also moved from
GroundQrCodetoQrCodeGeneratorand unit tests were added.@shobhitagarwal1612 PTAL?