Skip to content

Deflake ReallocUseAfterFree test. #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Deflake ReallocUseAfterFree test. #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tcmalloc/guarded_page_allocator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,11 @@ GuardedAllocationsErrorType GuardedPageAllocator::GetErrorType(
if (addr >= d.allocation_start + d.requested_size) {
return GuardedAllocationsErrorType::kBufferOverflow;
}
return GuardedAllocationsErrorType::kUnknown;
// If addr is within [d.allocation_start, d.allocation_start +
// d.requested_size) on a faulted Object Page where dealloc_count == 0,
// metadata was reset by concurrent slot recycling. It is guaranteed to be a
// Use-After-Free.
return GuardedAllocationsErrorType::kUseAfterFree;
}

uintptr_t GuardedPageAllocator::SlotToAddr(size_t slot) const {
Expand Down
Loading