Skip to content

Grant Gloop visibility into TCMalloc #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 10, 2026
+13 −9
Merged

Grant Gloop visibility into TCMalloc #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,11 @@ bazel_dep(name = "fuzztest", version = "20260219.0", dev_dependency = True, repo
bazel_dep(name = "google_benchmark", version = "1.9.5", dev_dependency = True, repo_name = "com_github_google_benchmark")
bazel_dep(name = "googletest", version = "1.17.0.bcr.2", dev_dependency = True, repo_name = "com_google_googletest")
bazel_dep(name = "rules_fuzzing", version = "0.5.2", dev_dependency = True)

# Note: Gloop is NOT a dev_dependency, but should never be used directly. It is only included here
# so that we can give visibility into TCMalloc internals.
bazel_dep(
name = "gloop",
version = "20260708.rc1",
repo_name = "do_not_use_for_gloop_visibility_only",
)
9 changes: 2 additions & 7 deletions tcmalloc/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ cc_library(
copts = TCMALLOC_DEFAULT_COPTS,
visibility = [
"//tcmalloc:__subpackages__",
"//tcmalloc:friends",
"@do_not_use_for_gloop_visibility_only//gloop:__subpackages__",
],
deps = [
":malloc_extension",
Expand Down Expand Up @@ -1600,6 +1600,7 @@ cc_library(
textual_hdrs = ["malloc_hook_invoke.h"],
visibility = [
":__subpackages__",
"@do_not_use_for_gloop_visibility_only//gloop/base:__pkg__",
],
deps = [
"//tcmalloc/internal:config",
Expand Down Expand Up @@ -1632,9 +1633,3 @@ cc_library(
],
alwayslink = 1,
)

# Expose internals to privileged external repositories.
package_group(
name = "friends",
packages = [],
)
5 changes: 3 additions & 2 deletions tcmalloc/internal/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ cc_library(
hdrs = ["linux_syscall_support.h"],
copts = TCMALLOC_DEFAULT_COPTS,
visibility = [
"//tcmalloc:friends",
"@do_not_use_for_gloop_visibility_only//gloop/base:__subpackages__",
],
)

Expand Down Expand Up @@ -1304,7 +1304,8 @@ cc_library(
visibility = [
"//tcmalloc:__pkg__",
"//tcmalloc:__subpackages__",
"//tcmalloc:friends",
"@do_not_use_for_gloop_visibility_only//gloop/base:__subpackages__",
"@do_not_use_for_gloop_visibility_only//gloop/concurrent/rcu:__subpackages__",
],
deps = [
":config",
Expand Down
Loading