Skip to content

chore(bigframes): check unused import and variables in nox commands#17264

Merged
sycai merged 1 commit into
mainfrom
sycai_nox_check_import
May 27, 2026
Merged

chore(bigframes): check unused import and variables in nox commands#17264
sycai merged 1 commit into
mainfrom
sycai_nox_check_import

Conversation

@sycai
Copy link
Copy Markdown
Contributor

@sycai sycai commented May 26, 2026

Added "F" (Pyflakes) rules to the nox commands, which check unused imports and variables.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on cleaning up the codebase by removing numerous unused imports, unused variables, and redundant f-string formatting across various modules and test files. Additionally, it updates the noxfile.py configuration to include Pyflakes (F) linting rules in ruff check to help automate the detection of unused imports in the future, and registers GeoStSimplifyOp in the operations package. There are no review comments, so I have no further feedback to provide.

@sycai sycai marked this pull request as ready for review May 26, 2026 21:31
@sycai sycai requested review from a team as code owners May 26, 2026 21:31
@sycai sycai requested review from shuoweil and removed request for a team May 26, 2026 21:31
@sycai sycai enabled auto-merge (squash) May 26, 2026 21:31
@sycai sycai added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels May 27, 2026
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 27, 2026
@sycai sycai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2026
@sycai sycai merged commit 0d9abb3 into main May 27, 2026
34 checks passed
@sycai sycai deleted the sycai_nox_check_import branch May 27, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants