fix(ci): increase import profiler absolute threshold #17779
Open
hebaalazzeh wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the --fail-threshold value from 5000 to 120000 in ci/run_single_test.sh when executing the profiler script. The feedback suggests double-quoting the ${PROFILER_SCRIPT} and ${PACKAGE_NAME} variables to prevent potential word splitting and globbing issues.
hebaalazzeh
marked this pull request as ready for review
July 20, 2026 18:30
hebaalazzeh
force-pushed
the
fix/import-profiler-warnings
branch
from
July 20, 2026 18:30
2e75bfa to
0b2d9fd
Compare
hebaalazzeh
force-pushed
the
fix/import-profiler-warnings
branch
4 times, most recently
from
July 20, 2026 19:14
37448ee to
99f6a31
Compare
hebaalazzeh
force-pushed
the
fix/import-profiler-warnings
branch
from
July 20, 2026 19:16
99f6a31 to
c13a5e7
Compare
parthea
reviewed
Jul 21, 2026
parthea
left a comment
parthea
left a comment
Contributor
There was a problem hiding this comment.
Can you create an example PR which includes changes to packages so we can see the results? Right now we only see No packages assigned to Shard 0. which is expected, but it would be great to see an example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements static matrix sharding for the
import-profilerworkflow to run modified packages in parallel across 8 shards, and sets the absolute failure/timeout threshold for each package import check to120s(2 minutes).Key Changes
.github/workflows/import-profiler.ymlto split modified package execution across 8 GHA runner shards using basic bash modulo logic.all-import-profilesstatus check that acts as the single required GitHub check.ci/run_single_test.shto120000ms(120 seconds / 2 minutes).