Skip to content

fix(sqlalchemy-bigquery): wrap string in WKT in geography system tests #17780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohmayr merged 2 commits into from
Jul 20, 2026
+6 −14
Merged

fix(sqlalchemy-bigquery): wrap string in WKT in geography system tests #17780

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b07017
fix(sqlalchemy-bigquery): wrap string in WKT in geography system test…
ohmayr Jul 20, 2026
2c3a586
style(sqlalchemy-bigquery): remove redundant WKT import in geography …
ohmayr Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions packages/sqlalchemy-bigquery/tests/system/test_geography.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
geoalchemy2 = pytest.importorskip("geoalchemy2")


# TODO(http://github.com/googleapis/google-cloud-python/issues/17287): Unskip once bug is resolved.
@pytest.mark.skip(reason="Failing in CI with AssertionError.")
def test_geoalchemy2_core(bigquery_dataset):
"""Make sure GeoAlchemy 2 Core Tutorial works as adapted to only having geography

Expand All @@ -44,7 +42,7 @@ def test_geoalchemy2_core(bigquery_dataset):

from sqlalchemy import Column, MetaData, String, Table

from sqlalchemy_bigquery import GEOGRAPHY
from sqlalchemy_bigquery import GEOGRAPHY, WKT

metadata = MetaData()
lake_table = Table(
Expand Down Expand Up @@ -86,7 +84,7 @@ def test_geoalchemy2_core(bigquery_dataset):

[[result]] = conn.execute(
select(lake_table.c.name).where(
func.ST_Contains(lake_table.c.geog, "POINT(4 1)")
func.ST_Contains(lake_table.c.geog, WKT("POINT(4 1)"))
)
)
assert result == "Orta"
Expand Down Expand Up @@ -119,8 +117,6 @@ def test_geoalchemy2_core(bigquery_dataset):

# and, while we're at it, that we can insert WKTs, although we
# normally wouldn't want to.
from sqlalchemy_bigquery import WKT

conn.execute(
lake_table.insert().values(
name="test2",
Expand All @@ -141,8 +137,6 @@ def test_geoalchemy2_core(bigquery_dataset):
)


# TODO(http://github.com/googleapis/google-cloud-python/issues/17287): Unskip once bug is resolved.
@pytest.mark.skip(reason="Failing in CI with AssertionError.")
def test_geoalchemy2_orm(bigquery_dataset):
"""Make sure GeoAlchemy 2 ORM Tutorial works as adapted to only having geometry

Expand All @@ -160,7 +154,7 @@ def test_geoalchemy2_orm(bigquery_dataset):
from sqlalchemy import Column, Integer, String
from sqlalchemy.ext.declarative import declarative_base

from sqlalchemy_bigquery import GEOGRAPHY
from sqlalchemy_bigquery import GEOGRAPHY, WKT
Comment thread
ohmayr marked this conversation as resolved.

Base = declarative_base()

Expand Down Expand Up @@ -224,19 +218,19 @@ class Lake(Base):

from sqlalchemy import func

query = session.query(Lake).filter(func.ST_Contains(Lake.geog, "POINT(4 1)"))
query = session.query(Lake).filter(func.ST_Contains(Lake.geog, WKT("POINT(4 1)")))

assert [lake.name for lake in query] == ["Orta"]

query = (
session.query(Lake)
.filter(Lake.geog.ST_Intersects("LINESTRING(2 1,4 1)"))
.filter(Lake.geog.ST_Intersects(WKT("LINESTRING(2 1,4 1)")))
.order_by(Lake.name)
)
assert [lake.name for lake in query] == ["Garde", "Orta"]

lake = session.query(Lake).filter_by(name="Garde").one()
assert session.scalar(lake.geog.ST_Intersects("LINESTRING(2 1,4 1)"))
assert session.scalar(lake.geog.ST_Intersects(WKT("LINESTRING(2 1,4 1)")))

# Use Other Spatial Functions
query = session.query(Lake.name, func.ST_Area(Lake.geog).label("area")).order_by(
Expand All @@ -258,8 +252,6 @@ class Lake(Base):
]


# TODO(http://github.com/googleapis/google-cloud-python/issues/17287): Unskip once bug is resolved.
@pytest.mark.skip(reason="Failing in CI with AssertionError.")
def test_geoalchemy2_orm_w_relationship(bigquery_dataset):
from sqlalchemy import create_engine

Expand Down
Loading