feat(google/maps/isochrones/v1): add google-maps-isochrones#17785
Conversation
PiperOrigin-RevId: 940577005
|
I put these pull requests as draft as you may want to setup OSS Exit Gates and PyPI registration before merging this. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new client library package, google-maps-isochrones, for the Google Maps Isochrones API, including its gRPC and REST transports, documentation, configuration files, and generated samples. Feedback on the changes highlights a critical issue with an invalid Ruff version specified in noxfile.py that will cause linting sessions to fail, as well as the omission of the generated unit test files for the new package.
|
|
||
| import nox | ||
|
|
||
| RUFF_VERSION = "ruff==0.14.14" |
There was a problem hiding this comment.
The specified Ruff version ruff==0.14.14 does not exist (Ruff versions are currently in the 0.x.y range, e.g., 0.4.14 or 0.8.4). This will cause pip install to fail during the lint, blacken, and format nox sessions. Please correct this to a valid version, such as ruff==0.4.14 or the standard version used across the repository.
| RUFF_VERSION = "ruff==0.14.14" | |
| RUFF_VERSION = "ruff==0.4.14" |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # |
There was a problem hiding this comment.
It appears that the actual unit test files (e.g., test_isochrone_service.py) are missing from this pull request. Since this is a new client library package, please ensure that the generated unit tests are included so that the test suite can run and verify the client's functionality.
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
🤖 I have created a release *beep* *boop* --- ## 0.1.0 (2026-07-21) ### Features * **google/maps/isochrones/v1:** add google-maps-isochrones ([#17785](#17785)) ([47a0db2](47a0db2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
2 participants
b/529841877
PiperOrigin-RevId: 940577005