feat(storage): implement transport, connector, worker by vsharonlynn · Pull Request #5956 · googleapis/google-cloud-rust

vsharonlynn · 2026-06-28T09:34:36Z

This PR comes after PR #5932.

gemini-code-assist

Code Review

This pull request introduces the appendable_object_writer module and supporting bidi_write infrastructure to enable bidirectional streaming writes for Google Cloud Storage. Key feedback includes avoiding .expect() on parameter conversions to prevent panics, simplifying complex string-folding logic, removing an unnecessary clone of the request object, and ensuring the background worker fails loudly with an explicit error if the stream closes unexpectedly while flushes are pending.

codecov · 2026-06-28T09:43:04Z

Codecov Report

❌ Patch coverage is 95.36862% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.73%. Comparing base (5e91002) to head (9cca986).

Files with missing lines	Patch %	Lines
src/storage/src/storage/bidi_write/worker.rs	82.03%	23 Missing ⚠️
src/storage/src/storage/bidi_write/transport.rs	96.03%	12 Missing ⚠️
src/storage/src/storage/bidi_write/connector.rs	98.03%	10 Missing ⚠️
src/storage/src/storage/bidi_write/redirect.rs	95.50%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5956      +/-   ##
==========================================
+ Coverage   97.72%   97.73%   +0.01%     
==========================================
  Files         242      246       +4     
  Lines       60882    61921    +1039     
==========================================
+ Hits        59495    60519    +1024     
- Misses       1387     1402      +15

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

joshuatants

We're gone through this extensively offline.

coryan

This is still too large. Aim for at most 200 lines of new code, which probably means 400 to 600 lines per PR. 1600 lines is simply too large.

coryan · 2026-06-30T12:02:05Z

+use std::sync::{Arc, Mutex};
+use std::time::Duration;
+use tokio::sync::mpsc::Sender;
+/// Represents a bidirectional streaming connection.


nit: blank line after the use declarations.

coryan · 2026-06-30T12:04:30Z

+        let resource = match req.spec.resource {
+            Some(r) => {
+                let object: crate::google::storage::v2::Object = gaxi::prost::ToProto::to_proto(r)
+                    .map_err(|e: gaxi::prost::ConvertError| Error::io(e.to_string()))?;


This is not an I/O error, this is a deserialization error, so you want:

Suggested change

.map_err(|e: gaxi::prost::ConvertError| Error::io(e.to_string()))?;

.map_err(Error::deser)?;

Please don't use e.to_string() when mapping errors, we want to preserve the error types, not just the error messages.

coryan · 2026-06-30T12:05:25Z

+        };
+        self.params = req
+            .params
+            .map(|p| p.to_proto().map_err(|e| Error::io(e.to_string())))


coryan · 2026-06-30T12:14:16Z


 //! Internal traits and types for Appendable Object Write (Bidi Write).

+#![allow(dead_code)]


Is there any way to have a smaller scope for this?

coryan · 2026-06-30T12:17:27Z

+                    match self.handle_response(m) {
+                        // Successful end of stream, return without error.
+                        None => break None,
+                        // An unrecoverable in the stream or its data, return


Suggested change

// An unrecoverable in the stream or its data, return

// An unrecoverable error in the stream or its data, return

coryan · 2026-06-30T12:20:12Z

+use tokio::sync::oneshot;
+
+type WriteResult<T> = std::result::Result<T, WriteError>;
+type LoopResult<T> = std::result::Result<T, Arc<crate::Error>>;


Why is this an Arc<crate::Error> ? That is only needed if more than one caller needs to receive the same error, which happens in bidi streaming reads, but it is not clear it could happen on bidi writes. I would expect there is only one writer at a time?

vsharonlynn · 2026-07-02T05:44:31Z

This is still too large. Aim for at most 200 lines of new code, which probably means 400 to 600 lines per PR. 1600 lines is simply too large.

Ok. I am going to split this PR into smaller PRs. I'll update once done. Thank you and sorry about this!

product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jun 28, 2026

gemini-code-assist Bot reviewed Jun 28, 2026

View reviewed changes

vsharonlynn mentioned this pull request Jun 28, 2026

feat(storage): implement API, request builders, integration tests #5957

Open

joshuatants reviewed Jun 29, 2026

View reviewed changes

Comment thread src/storage/src/storage/bidi_write/connector.rs Outdated

Comment thread src/storage/src/storage/bidi_write/redirect.rs Outdated

Comment thread src/storage/src/storage/bidi_write/transport.rs Outdated

vsharonlynn force-pushed the appendable_upload_3 branch 8 times, most recently from f3e8345 to 4c4b7be Compare June 29, 2026 11:57

vsharonlynn marked this pull request as ready for review June 29, 2026 12:02

vsharonlynn requested review from a team as code owners June 29, 2026 12:02

vsharonlynn force-pushed the appendable_upload_3 branch from 4c4b7be to ce34c25 Compare June 29, 2026 13:29

vsharonlynn added 7 commits June 29, 2026 17:12

feat(storage): implement transport, connector, worker

07b7af7

Incorporate feedback

005537a

Incorporate feedback

a4ef212

Incorporate feedback

b529ee4

Incorporate feedback

1a15a5a

Fix failing tests, format, lint, clippy, dead code

80f3311

Fix bugs

9cca986

vsharonlynn force-pushed the appendable_upload_3 branch from 1713d73 to 9cca986 Compare June 29, 2026 17:13

joshuatants approved these changes Jun 30, 2026

View reviewed changes

coryan requested changes Jun 30, 2026

View reviewed changes

	.map_err(\|e: gaxi::prost::ConvertError\| Error::io(e.to_string()))?;
	.map_err(Error::deser)?;

	.map(\|p\| p.to_proto().map_err(\|e\| Error::io(e.to_string())))
	.map(\|p\| p.to_proto().map_err(\|Error::ser)


		//! Internal traits and types for Appendable Object Write (Bidi Write).

		#![allow(dead_code)]

	// An unrecoverable in the stream or its data, return
	// An unrecoverable error in the stream or its data, return

Uh oh!

Conversation

vsharonlynn commented Jun 28, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joshuatants left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coryan left a comment

Choose a reason for hiding this comment

Uh oh!

coryan Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

coryan Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

coryan Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

coryan Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

coryan Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

coryan Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

vsharonlynn commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Jun 28, 2026 •

edited

Loading