Bug Bash 2026-08: fix issues in agentic_roof_edge_detection.ipynb - #79
Open
akshitmeghawat wants to merge 1 commit into
Open
Bug Bash 2026-08: fix issues in agentic_roof_edge_detection.ipynb#79akshitmeghawat wants to merge 1 commit into
akshitmeghawat wants to merge 1 commit into
Conversation
akshitmeghawat
force-pushed
the
bugbash
branch
3 times, most recently
from
August 10, 2026 20:21
a850957 to
5edb3a2
Compare
…c_roof_edge_detection.ipynb
akshitmeghawat
force-pushed
the
bugbash
branch
from
August 10, 2026 20:23
5edb3a2 to
b1dc7c2
Compare
bijanvakili
reviewed
Aug 10, 2026
| " project_id = auth_project\n", | ||
| " print(f\"[INFO] Auto-detected Google Cloud Project: {project_id}\")\n", | ||
| " except Exception:\n", | ||
| " pass #@param {type:\"string\"} #@param {type:\"string\"}\n", |
Collaborator
There was a problem hiding this comment.
Move the #@param {type:\"string\"} to be the comment for project_id on line 49
This will force it to become a form parameter.
| "client = genai.Client(vertexai=True, project=project_id, location='global')\n", | ||
| "\n", | ||
| "\n", | ||
| "# ==============================================================================\n", |
Collaborator
There was a problem hiding this comment.
I recommend splitting each of these steps into separate cells
| "# ==============================================================================\n", | ||
| "observation_id = 'o1:8pyvx-2PAvgnsnSzN_q7Xg_2:5001ee' #@param {type:\"string\"}\n", | ||
| "# observation_id = 'o1:8pyvx-2PAvgnsnSzN_q7Xg_2:5001ee' #@param {type:\"string\"}\n", | ||
| "observation_id = 'o1:vkmqpCyhedkriBfyh0lAAw_4:5001ee'\n", |
Collaborator
There was a problem hiding this comment.
Please keep the #@param {type:"string"} comment to ensure it is still a form parameter.
| "observation_id = 'o1:vkmqpCyhedkriBfyh0lAAw_4:5001ee'\n", | ||
| "dataset_id = 'imagery_insights___us'\n", | ||
| "urls_table_name = 'urls_new'\n", | ||
| "urls_table_name = 'pano_observations_latest'\n", |
Collaborator
There was a problem hiding this comment.
url_table_name -> table_name
Remove the uri_field_anem as this does not need to be a parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes