Skip to content

Remove unsupported place details scope field mask #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madtriceps wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Remove unsupported place details scope field mask #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/com/google/maps/PlaceDetailsRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,6 @@ public enum FieldMask implements UrlValue {
@Deprecated
REVIEW("review"),
REVIEWS("reviews"),
@Deprecated
SCOPE("scope"),
SERVES_BEER("serves_beer"),
SERVES_BREAKFAST("serves_breakfast"),
SERVES_BRUNCH("serves_brunch"),
Expand Down
7 changes: 7 additions & 0 deletions src/test/java/com/google/maps/PlacesApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,13 @@ public void testPlaceDetailsRequest() throws Exception {
}
}

@Test
public void testPlaceDetailsFieldMasksDoNotIncludeUnsupportedScope() {
for (PlaceDetailsRequest.FieldMask fieldMask : PlaceDetailsRequest.FieldMask.values()) {
assertFalse("scope".equals(fieldMask.toUrlValue()));
}
}

@Test
public void testAutocompletePredictionStructuredFormatting() throws Exception {
try (LocalTestServerContext sc =
Expand Down