Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 54 additions & 2 deletions src/app/services/file-download-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,48 @@ const APPLICATION_TEXT_MIME_TYPES = new Set([
"application/sql",
]);

export function isTextMimeType(mimeType: string | undefined): boolean {
const TEXT_FILE_EXTENSIONS = new Set([
"svelte",
"vue",
"ts",
"tsx",
"jsx",
"mjs",
"cjs",
"go",
"rs",
"rb",
"py",
"java",
"c",
"cpp",
"h",
"hpp",
"cs",
"swift",
"kt",
"kts",
"sh",
"bash",
"yaml",
"yml",
"toml",
"ini",
"cfg",
"md",
"mdx",
"css",
"scss",
"less",
"html",
"htm",
"graphql",
"gql",
"proto",
"gradle",
]);

export function isTextMimeType(mimeType: string | undefined, filename?: string): boolean {
if (!mimeType) {
return false;
}
Expand All @@ -117,5 +158,16 @@ export function isTextMimeType(mimeType: string | undefined): boolean {
return true;
}

return APPLICATION_TEXT_MIME_TYPES.has(mimeType);
if (APPLICATION_TEXT_MIME_TYPES.has(mimeType)) {
return true;
}

if (filename) {
const ext = filename.split(".").pop()?.toLowerCase();
if (ext && TEXT_FILE_EXTENSIONS.has(ext)) {
return true;
}
}

return false;
}
2 changes: 1 addition & 1 deletion src/bot/handlers/document-handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export async function handleDocumentMessage(
const filename = doc.file_name || "document";

try {
if (isTextMimeType(mimeType)) {
if (isTextMimeType(mimeType, filename)) {
if (!isFileSizeAllowed(doc.file_size, config.files.maxFileSizeKb)) {
logger.warn(
`[Document] Text file too large: ${filename} (${doc.file_size} bytes > ${config.files.maxFileSizeKb}KB)`,
Expand Down
2 changes: 1 addition & 1 deletion src/bot/handlers/media-group-handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export class MediaGroupAttachmentHandler {
const mimeType = document.mime_type || "";
const filename = document.file_name || "document";

if (isTextMimeType(mimeType)) {
if (isTextMimeType(mimeType, filename)) {
if (!isFileSizeAllowed(document.file_size, config.files.maxFileSizeKb)) {
return { reason: "text_file_too_large" };
}
Expand Down
30 changes: 30 additions & 0 deletions tests/app/services/file-download-service.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,36 @@ describe("app/services/file-download-service", () => {
it("returns false for empty string", () => {
expect(isTextMimeType("")).toBe(false);
});

it("returns true for unknown MIME with known code file extension", () => {
expect(isTextMimeType("application/octet-stream", "component.svelte")).toBe(true);
expect(isTextMimeType("application/octet-stream", "App.vue")).toBe(true);
expect(isTextMimeType("application/octet-stream", "main.tsx")).toBe(true);
expect(isTextMimeType("application/octet-stream", "server.go")).toBe(true);
expect(isTextMimeType("application/octet-stream", "script.py")).toBe(true);
});

it("returns false for unknown MIME with unknown extension", () => {
expect(isTextMimeType("application/octet-stream", "file.xyz")).toBe(false);
expect(isTextMimeType("application/octet-stream", "archive.7z")).toBe(false);
});

it("returns false for unknown MIME without filename", () => {
expect(isTextMimeType("application/octet-stream")).toBe(false);
});

it("returns false for undefined MIME even with known extension", () => {
expect(isTextMimeType(undefined, "file.svelte")).toBe(false);
});

it("handles files with multiple dots correctly", () => {
expect(isTextMimeType("application/octet-stream", "Component.test.svelte")).toBe(true);
expect(isTextMimeType("application/octet-stream", "some.file.with.dots.py")).toBe(true);
});

it("handles files with no extension", () => {
expect(isTextMimeType("application/octet-stream", "Dockerfile")).toBe(false);
});
});
});

Expand Down
Loading