Skip to content

Implement Promo Sticker for iOS#402

Open
tkgnm wants to merge 7 commits into
mainfrom
promo-sticker
Open

Implement Promo Sticker for iOS#402
tkgnm wants to merge 7 commits into
mainfrom
promo-sticker

Conversation

@tkgnm

@tkgnm tkgnm commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

Figma: https://www.figma.com/design/kSmjgtoTWiG8N7HXxFoGEE/%E2%97%90-Apps-library?node-id=15923-91&p=f&t=ZFSlkDxFTvXxG3EC-0

Here we add the Promo Sticker component and its four default styles. Also added to the Sourcy app. PR of its use in the live app here.

Testing notes/instructions:

A screenshot should suffice in this case but feel free to use the promo sticker builder in the Sourcy app.

Checklist

  • Changes have been checked by the developer
  • Changes have been checked by the reviewers
  • Unit tested
Recommended reviewers
  • Design review for UI changes from @guardian/design-system
  • Code review from @guardian/android-developers or @guardian/ios-developers
  • Optional code/API review from @guardian/client-side-infra

For pull requests introducing UI changes:

  • Sign-off by Design:
  • Dark Mode
  • Tablet
  • Accessibility (e.g. VoiceOver):
Screenshots or videos:

Component

Light Dark
Screenshot 2026-07-03 at 18 48 43 Screenshot 2026-07-03 at 18 48 50

Sourcy

Simulator Screenshot - iPhone 17 Pro - 2026-07-03 at 12 38 52

Copilot AI review requested due to automatic review settings July 2, 2026 18:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “Promo sticker” SwiftUI component to the Source design system package, including sizing, theming, and optional corner-specific rounding for overlay use.

Changes:

  • Introduces PromoStickerView with two sizes and an optional CornerPlacement for uneven corner rounding.
  • Adds PromoStickerTheme presets (blue/red/purple/green) and a PromoStickerSize enum.
  • Includes a #Preview showcasing variants and corner placements.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.

File Description
Sources/Source/PromoSticker/PromoStickerView.swift New SwiftUI view for rendering the promo sticker, plus previews and corner rounding support.
Sources/Source/PromoSticker/PromoStickerTheme.swift Adds a theme type and preset color themes for the sticker.
Sources/Source/PromoSticker/PromoStickerSize.swift Adds size enum for small/large variants.
Sources/Source/PromoSticker/CornerPlacement.swift Adds corner-placement enum used to derive per-corner radii.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Sources/Source/PromoSticker/PromoStickerTheme.swift
Comment thread Sources/Source/PromoSticker/PromoStickerTheme.swift
Comment thread Sources/Source/PromoSticker/PromoStickerTheme.swift
Comment thread Sources/Source/PromoSticker/PromoStickerTheme.swift
Comment thread Sources/Source/PromoSticker/PromoStickerTheme.swift
Comment thread Sources/Source/PromoSticker/PromoStickerView.swift
Comment thread Sources/Source/PromoSticker/CornerPlacement.swift Outdated
Comment thread Sources/Source/PromoSticker/PromoStickerView.swift Outdated
Comment thread Sources/Source/PromoSticker/PromoStickerView.swift
Comment thread Sources/Source/PromoSticker/PromoStickerView.swift
@tkgnm tkgnm added the feature Departmental tracking: work on a new feature label Jul 3, 2026
@tkgnm tkgnm changed the title Promo sticker Implement Promo Sticker for iOS Jul 3, 2026
.background {
container
.fill(theme.backgroundColor)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra empty space here

@alidinc alidinc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants