Conversation
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates the project’s CI publishing workflows to install an IDN-related system dependency and modernize package publishing steps for PyPI and npm.
Changes:
- Add
libidn-devinstallation to the GitHub Pages site publish workflow. - Update PyPI publish action reference and adjust inputs.
- Update Node publishing workflow to use a newer Node version, switch caching strategy, and change the auth token source.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/publish-site.yml | Installs a system dependency (libidn-dev) prior to running the site publish steps. |
| .github/workflows/publish-pypi.yml | Switches PyPI publish action version/alias and modifies publish inputs. |
| .github/workflows/publish-npm.yml | Changes Node version + caching strategy and updates npm publish authentication token. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+14
to
+16
| - name: Install Dependencies | ||
| run: sudo apt install libidn-dev | ||
|
|
Comment on lines
+58
to
+62
| - name: Publish to PyPI | ||
| # Note: No "password" or "api-token" secret is referenced here | ||
| uses: pypa/gh-action-pypi-publish@release/v1 | ||
| with: | ||
| packages_dir: ./_packages/python/dist/ | ||
| print_hash: true | ||
| user: __token__ | ||
| password: ${{ secrets.PYPI_API_TOKEN }} | ||
| packages-dir: ./_packages/python/dist/ No newline at end of file |
Comment on lines
+34
to
36
| node-version: 24 | ||
| cache: bun | ||
| registry-url: https://registry.npmjs.org/ |
Comment on lines
44
to
+47
| - name: Publish to NPM Registry | ||
| run: yarn publish _packages/node/ | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{secrets.npm_token}} | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.