Skip to content

Windows: link manifest records Vulkan import lib as vulkan, breaking non-CMake consumers (LNK1181) #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MorrisonLiu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Windows: link manifest records Vulkan import lib as vulkan, breaking non-CMake consumers (LNK1181) #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion cmake/transcribe-install.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,18 @@ if(NOT TRANSCRIBE_BUILD_SHARED)
list(APPEND _frameworks Accelerate)
endif()
if("vulkan" IN_LIST _kinds)
list(APPEND _system_libs vulkan)
# The Vulkan import library's basename is platform-specific: Windows'
# LunarG SDK ships `vulkan-1.lib` (the import lib for the
# driver-installed vulkan-1.dll loader); every other platform links
# `libvulkan`. Emit the right name per-OS so a non-CMake consumer
# reconstructing the link line from this manifest resolves it — a bare
# `vulkan` becomes `vulkan.lib` on MSVC, which the SDK does not provide,
# so the link dies with LNK1181.
if(WIN32)
list(APPEND _system_libs vulkan-1)
else()
list(APPEND _system_libs vulkan)
endif()
endif()
if(_frameworks)
list(REMOVE_DUPLICATES _frameworks)
Expand Down