Render agent-style TeX delimiters as math - #261
Draft
richwomanbtc wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\(...\)and standalone\[...\]delimiters into the enriched renderer's supported math syntaxRoot cause
The enriched Markdown renderer already enables MD4C's LaTeX math extension, but that parser recognizes
$...$and$$...$$, while coding agents commonly emit\(...\)and\[...\]. Those delimiters therefore remained literal. Tables also use the legacy block renderer, so math cells needed an explicit path into the enriched renderer.Validation
36/36focused math and table tests passed on this math-only branchgit diff --check upstream/dev...agent/render-agent-tex-mathpassedzoddependencyDraft status
iPhone live rendering is not yet verified. The local development client was installed and reached the native bundle path, but the shared QA server could not safely complete the first Metro bundle under its memory constraints. This remains an explicit live-QA gap rather than a passing result.
Fixes #257
Related: slopus/happy#1629
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Render agent-style TeX math delimiters (
\(...\)and\[...\]) in markdownnormalizeEnrichedMarkdownMathDelimitersto convert Codex-style\(...\)/\[...\]delimiters to$/$$before passing markdown to the enriched renderer, skipping protected regions like code spans, links, and URLs.EnrichedMarkdownTextAdapter(using the newRenderTableCellContenthelper) when math is detected, falling back to plainTextotherwise.EnrichedMarkdownTextAdaptergains afillContainerprop to suppress full-width stretching in table cell contexts, and math/paragraph alignment now respects the incomingtextStyle.textAlign.profileprop inMarkdownBlockView.Macroscope summarized f63eb67.