feat(grpc): hard-cut to v1 grpc interface#80
Merged
Conversation
StopVm now returns StopVmResponse; ListVms takes ListVmsRequest. Empty can never grow a field; purpose-built messages keep both RPCs extensible.
InstanceType/Architecture gain a *_UNSPECIFIED = 0 sentinel; real values shift up one. An omitted instance_type/arch is now INVALID_ARGUMENT rather than a silent MICRO/x86_64 default (AIP-126).
page_size/page_token on the request, next_page_token on the response. A pure Hyper.Grpc.Page core cursors by vm_id over Cluster.Routing.all/0; the keyset cursor is robust to the registry changing mid-listing.
Freeze the cleaned-up contract as the first stable version. Service address is now hyper.grpc.v1.Hyper; generated bindings move to Hyper.Grpc.V1.*. BREAKING CHANGE: clients must target the hyper.grpc.v1 package.
Swap v0->v1 throughout, replace the google.protobuf.Empty examples with the dedicated ListVms/StopVm messages, document required enum fields and the paged ListVms flow, and the v2-side-by-side stability policy.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
markovejnovic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.