ETT-316 issues with glacier expiration job (mass_delete edition)#190
Open
moseshll wants to merge 1 commit into
Open
ETT-316 issues with glacier expiration job (mass_delete edition)#190moseshll wants to merge 1 commit into
mass_delete edition)#190moseshll wants to merge 1 commit into
Conversation
- Add a `mass_delete` class method to the `ObjectStore` and `PrefixedVersions` storage classes. - Intended to replace the `delete_objects` instance method. - Add companion `object_keys` instance so these can be amassed at a higher level and removed via `mass_delete`. - `BackupExpirationBatch` can still take an arbitrarily large batch size, but due to s3api delete-objects limitation of 1k objects it iterates sub-batches of just under 1k. This way there's no need to mess with the job-size parameter in the parent binary. - Switch to a single `mass_delete` storage call per subbatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mass_deleteclass method to theObjectStoreandPrefixedVersionsstorage classes.delete_objectsinstance method.object_keysinstance method so these can be amassed at a higher level and removed viamass_delete.BackupExpirationBatchcan still take an arbitrarily large batch size, but due to s3api delete-objects limitation of 1k objects it iterates sub-batches of just under 1k. This way there's no need to mess with the job-size parameter in the parent binary.mass_deletestorage call per subbatch.