Checker improvements and fixes#60
Conversation
a17d36f to
456e8ca
Compare
carylwyatt
left a comment
There was a problem hiding this comment.
Overall, these are some excellent updates! I'm glad Natalie tested it out with some more robust examples of submissions, she caught a lot more things that could go sideways.
Thanks for all your work on this, it's going to be an amazing addition to our toolset!
| const historySection = document.getElementById('history-section'); | ||
| const historyList = document.getElementById('history-list'); | ||
|
|
||
| // Persisted via localStorage so history survives a page reload/revisit. |
There was a problem hiding this comment.
I'm very curious about the backstory on this history section. I'm assuming Natalie asked for it, can you explain a little about why we're storing this info about the file submissions?
Since localStorage doesn't have an expiration date, can we add a "clear history" button for folks who don't want their history stored? Librarians are generally conscious of privacy concerns, and while this data is only stored in their browser, let's give them a way to opt out.
| // Blocks obviously wrong drops up front, but lets text-like extensions | ||
| // through so their filename/column/row problems are reported too. | ||
| // validateFilename() still flags the extension as an error. | ||
| function isTextLikeFile(fileName) { |
There was a problem hiding this comment.
Nice improvement! It has happened in the past where we get the wrong file type but more-or-less correct data.
| </section> | ||
|
|
||
| <section class="checker-instructions" aria-label="File format requirements"> | ||
| <h2>File format requirements</h2> |
There was a problem hiding this comment.
I love the addition of this requirements list! 💯
Available to test in dev: https://dev-3.www.hathitrust.org/print-holdings-checker/
I added more detailed instructions, history, and some improvements and fixes.
umich_monographs_Full_122122023.tsvumich_..._Copy.txt.txt/.csvfiles now get checked fully instead of just rejectedumich_spm_full_20230711.tsv.txtumich Hathi 2023.1-DS.tsvumich_multi-part_20230531.tsvumich_mon_Full_12122023.tsv.tsvumich_mpm_full_20230316 (1).tsv