fix: propagate kubectl error in GetPodsforDeployment, compile regexp once#839
Open
immanuwell wants to merge 1 commit into
Open
fix: propagate kubectl error in GetPodsforDeployment, compile regexp once#839immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
…once Signed-off-by: immanuwell <pchpr.00@list.ru>
860d01a to
68e0ac1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Two small fixes:
GetPodsforDeploymentwas silently dropping the error fromkubectl get deployment. When kubectl fails you'd get a confusingunexpected end of JSON inputinstead of the actual error. One-liner fix - just stop ignoring the err.SanitizeNamewas callingregexp.MustCompileon every invocation. The regex is constant so it should be compiled once at package level (same pattern already used inaccount.goright next door).Bonus: trimmed a stray trailing space off an error string in
CheckVersionIncrement.How to reproduce:
For (1): call
GetPodsforDeploymentwith a deployment name that doesn't exist or when kubectl isn't configured - you'll seeunexpected end of JSON inputinstead of the real kubectl error.For (2):
SanitizeNameis called inCreateInstallParamsfor every chart install, so the regex gets recompiled on each run. No functional impact but wasteful.Special notes for your reviewer:
All existing tests pass, no behavior change for (2) and (3), (1) now surfaces the real error earlier.