Serve private docs on hyphenated org subdomains#121
Merged
Conversation
Org names allow underscores, but RFC 1123 hostname labels and Fastly's strict SAN matching don't, so map `_` -> `-` for `*.hexorgs.pm` subdomains, mirroring the public package side. The hexorgs.pm path is served by this app rather than Fastly, so the reverse `-` -> `_` mapping and the 301 from the old underscore host both live in the plug. - Utils: add name_to_subdomain/1 and subdomain_to_name/1 (replacing package_to_subdomain/1); hexdocs_url/3 now hyphenates the org subdomain. - Plug: 301-redirect underscore hosts to the hyphenated host (preserving path and query); reverse-map the subdomain to the org name for the OAuth scope, key verification and bucket key; build the OAuth redirect_uri with the hyphenated host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Org names allow underscores, but RFC 1123 hostname labels and Fastly's strict SAN matching don't, so map
_->-for*.hexorgs.pmsubdomains, mirroring the public package side. The hexorgs.pm path is served by this app rather than Fastly, so the reverse-->_mapping and the 301 from the old underscore host both live in the plug.