Refactor: make NavSearch globally accessible via Navbar - #101
Open
SRUTHIAGARWAL wants to merge 1 commit into
Open
Refactor: make NavSearch globally accessible via Navbar#101SRUTHIAGARWAL wants to merge 1 commit into
SRUTHIAGARWAL wants to merge 1 commit into
Conversation
✅ Deploy Preview for smartrentsystem ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
|
@SRUTHIAGARWAL follow pr templates after merge pr |
Author
|
@hitesh-kumar123 I have now updated my PR according to the template. Please review it once again. Thank you. |
Author
|
@hitesh-kumar123 if there are any other things to be added yet please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: "📦 Pull Request"
about: Submit changes for review
title: "PR: Make NavSearch globally accessible via Navbar"
📌 Linked Issue
Closes #94
🛠 Changes Made
NavSearchcomponent insideNavbarHomeNavbar/listingsfrom all pages🧪 Testing
Ran unit tests (
npm test): NoTested manually:
📸 UI Changes (if applicable)
| Before |
| Search limited to Home page |
After
|Search available globally via Navbar |
📝 Documentation Updates
Updated README/docs: No
Added code comments: Yes
✅ Checklist
Created a new branch for PR: Yes
Have starred the repository: Yes
Follows JavaScript Styleguide: Yes
No console warnings/errors: Yes
Commit messages follow Git Guidelines: Yes
💡 Additional Notes (If any)
This PR is frontend-only and does not impact backend or authentication logic.
It improves UX consistency and reduces duplicated state management.