Convert to ESModules & export everything#20
Open
NatoBoram wants to merge 8 commits into
Open
Conversation
import { functionsTokensEstimate } from 'openai-chat-tokens';
type FunctionDef = Parameters<typeof functionsTokensEstimate>[0][number];
type ObjectProp = FunctionDef['parameters'];Maybe you can try like this. |
Author
|
Yeah, that's true. I ended up re-publishing the package under https://github.com/coderabbitai/openai-chat-tokens to avoid dealing with more type aliases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
While using this package, I needed to import some private types. There were also some imports that were very tricky to use, so I moved the package to ESModules for better compatibility. I also encountered an issue while using Jest; it seems like it's severely outdated as its ESModule support is experimental. Switching to Vitest made it work without having a config file.
With this change, instead of:
It's now: