460 etl timezone#462
Open
kjlippold wants to merge 2 commits into
Open
Conversation
kjlippold
commented
Jul 6, 2026
Contributor
- Updated parse_series_to_utc to preserve timestamp timezones when provided, and handle mixed tz-aware/tz-naive timeseries.
- Added missing argument to ETL CSVTransformer.
daniel-slaugh
requested changes
Jul 6, 2026
daniel-slaugh
left a comment
Contributor
There was a problem hiding this comment.
I ran this locally and the happy path works as expected.
I found one nitpick bug: If the timezone information is hour only like 2024-01-01T12:00:00-07, timestamp.py will crash the batch since the timestamp is misclassified as naive, tries to localize, and throws a TypeError. I recommend adding support for this since we'll probably have a user at some point that uses this timestamp format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.