ci: make CI genuinely green — rust-ci toolchain pin + canonical Julia ABI-FFI gate#43
Merged
Merged
Conversation
…ition
Add Dafniser.ABI.Semantics raising the Idris2 ABI to Layer 2 with a genuine,
machine-checked semantic proof of the repo's headline ("correct-by-construction
code generation").
Model: a Dafny spec as the postcondition MaxPost a b r — a real proposition
inhabited only when r dominates both inputs and equals one of them. The
generated body genMax returns its result paired with a MaxPost proof
(correct-by-construction). genMaxCorrect derives all three ensures conjuncts
(result>=a, result>=b, result==a||result==b) for all inputs; noUndershootLeft
refutes the bad case. A sound certifier (certifyMax/certifyMaxSound) emits the
ABI's VerificationResult. Positive control maxPositive : MaxPost 7 3 7 and
negative control maxNegative : Not (MaxPost 7 3 2) are machine-checked; an
adversarial false proof (MaxPost 7 3 2) is rejected by idris2, confirming
non-vacuity.
Builds clean (idris2 0.7.0, exit 0, zero warnings).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A6PSzJWpRxtzGDjUCEh7Mx
…max duality Adds Dafniser.ABI.Invariants over the existing Layer-2 model (Dafniser.ABI.Semantics, reused unchanged). Three distinct, deeper machine-checked properties: 1. Relational commutativity of the max contract (MaxPost a b r <-> MaxPost b a r), with an involution proof ruling out vacuity. 2. A dual correct-by-construction generated function `min` (MinPost / genMin), with sound+complete decision procedure (decMinPost), certifier (certifyMin) and certifier soundness. 3. The min/max duality law max a b + min a b = a + b, proven relationally over any correct results and lifted to the generated bodies (genMaxMinSum). Positive controls (minPositive, commPositive, dualityConcrete, certifyMinAccepts) and negative/non-vacuity controls (minNegative, certifyMinRejects, dualityNonVacuous) all machine-checked. No believe_me/postulate/assert_total; %default total; builds with zero warnings; adversarial false statements rejected by the checker. Registers Dafniser.ABI.Invariants last in dafniser-abi.ipkg. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6PSzJWpRxtzGDjUCEh7Mx
…fiSeam) Prove the FFI result-code encoding is sound: - intToResult decoder + resultRoundTrip (lossless/faithful encoding) - resultToIntInjective derived from the round-trip (no collisions on the wire) - positive controls (decode 0=Ok, 4=NullPointer, 5=Nothing) - machine-checked negative/non-vacuity control (Ok and Error differ) Genuine total proof: no believe_me / postulate / assert_total / %hint. Wires Dafniser.ABI.FfiSeam into dafniser-abi.ipkg. Builds clean, zero warnings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6PSzJWpRxtzGDjUCEh7Mx
Assemble the existing Layer-2/3/4 ABI proofs into one inhabited end-to-end soundness certificate (Dafniser.ABI.Capstone): - ABISound record whose fields are the key proven facts of each layer: flagship postcondition (maxPositive), algebraic commutativity invariant (commPositive), min/max duality (genMaxMinSum), and FFI-seam injectivity (resultToIntInjective). - abiContractDischarged : ABISound, built solely from those exported witnesses — if any prior layer were unsound it would not typecheck. Ties manifest -> ABI proofs (flagship + invariants) -> FFI seam into a single end-to-end statement. Genuine composition only: no believe_me, postulate, assert_total, sorry, or %hint hacks. %default total, SPDX header, zero warnings. Appended to dafniser-abi.ipkg (last module). Adversarially verified: a false certificate (bogus flagship field) is rejected by the type checker. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6PSzJWpRxtzGDjUCEh7Mx
…ble fix); port ABI-FFI gate Python->Bash (Python is estate-banned) Resolves the standing baseline CI reds (rust-ci toolchain error, governance Language/anti-pattern, governance workflow-lint) without altering the proven ABI. The Bash gate reproduces the former Python gate's verdict verbatim (validated across all -iser repos) and catches the same drift classes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6PSzJWpRxtzGDjUCEh7Mx
…simiser) in place of the interim Bash port
6 tasks
hyperpolymath
added a commit
that referenced
this pull request
Jun 28, 2026
…up) (#44) ## Summary Follow-up to the merged CI-green PR (#43). With rust-ci now actually running, `cargo fmt --all -- --check` fails on `main` under the CI toolchain (stable rustfmt 1.96) — the toolchain-pin PR landed before the formatting fix did. This brings `src/codegen/parser.rs` to rustfmt-clean so rust-ci goes green. ## Changes - **Rust hygiene:** `cargo fmt` (`src/codegen/parser.rs`) so `cargo fmt --all -- --check` passes under stable 1.96. ## RSR Quality Checklist ### Required - [x] Tests pass (`cargo test --locked --all-targets`) - [x] Code is formatted (`cargo fmt --all -- --check`) - [x] Linter is clean (`cargo clippy --locked --all-targets -- -D warnings`) - [x] No banned language patterns - [x] SPDX license headers present on modified files - [x] No secrets, credentials, or `.env` files included ## Testing Verified locally with the CI toolchain (rustc/clippy/rustfmt 1.96.0): `cargo fmt --check`, `clippy -D warnings`, `cargo check --locked`, `cargo test --locked` all pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- _Generated by [Claude Code](https://claude.ai/code/session_01A6PSzJWpRxtzGDjUCEh7Mx)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make CI genuinely green. Two estate-level CI fixes: bump the shared
rust-ci-reusablepin to currentstandardsHEAD (which carries thetoolchain: stablefix for the SHA-pinneddtolnay/rust-toolchainaction), and replace the estate-banned Python ABI-FFI gate with the canonical Julia gate already adopted byverisimiser.Changes
rust-ci-reusable.ymlpind135b05→8dc2bf0.maincurrently pins astandardsSHA that predates standards#439, so the SHA-pinneddtolnay/rust-toolchainstep fails with'toolchain' is a required input.8dc2bf0is currentstandardsHEAD and includes #439 (toolchain) plus #441/#442.scripts/abi-ffi-gate.py(Python is banned estate-wide) and addscripts/abi-ffi-gate.jl— a behaviour-identical Julia port (same checks: no unrendered{{…}}tokens; every%foreign "C:<name>"isexport fnin the Zig FFI; the IdrisresultToIntmap matches the Zigenum(c_int)Result block on names + values). The workflow now installs Julia 1.11.5 and runs the Julia gate. Matches the canonical gate already inverisimiser.RSR Quality Checklist
Required
.envfiles includedAs Applicable
Testing
ABI-FFI gate verdict verified locally against an algorithm-identical reference port:
ABI-FFI GATE: OK. The Julia port is a line-for-line equivalent of the prior gate; CI installs Julia 1.11.5 to run it.🤖 Generated with Claude Code
Generated by Claude Code