Skip to content

Harden permission checks and cache behavior #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
binaryfire merged 14 commits into from
Jul 3, 2026
Merged

Harden permission checks and cache behavior #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
aa44bb4
docs: add permission hardening plan
binaryfire Jul 3, 2026
b88460a
refactor(permission): remove storage connection option
binaryfire Jul 3, 2026
087d74d
fix(permission): handle authenticated users without authorizable
binaryfire Jul 3, 2026
96ffae6
fix(permission): parse malformed pipe role strings correctly
binaryfire Jul 3, 2026
3f6c62b
fix(permission): scope reverse role assignments by team
binaryfire Jul 3, 2026
f5c0ef1
perf(permission): avoid redundant role assignment cache clears
binaryfire Jul 3, 2026
7ede82e
perf(permission): index registrar catalog and runtime caches
binaryfire Jul 3, 2026
98cbde0
fix(permission): harden role and permission lookups
binaryfire Jul 3, 2026
4e672dc
fix(permission): enforce scoped deny semantics
binaryfire Jul 3, 2026
dce4912
docs(permission): document final cache and deny behavior
binaryfire Jul 3, 2026
79745d0
fix(permission): make direct creation race-safe
binaryfire Jul 3, 2026
ff5260f
test(permission): cover team-aware role find or create
binaryfire Jul 3, 2026
f415fbc
test(permission): add package database integration convention
binaryfire Jul 3, 2026
6cab5ce
fix(permission): restore soft-deleted records on find or create
binaryfire Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/databases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
DB_DATABASE: testing
DB_USERNAME: root
DB_PASSWORD: password
run: vendor/bin/phpunit tests/Integration/Database
run: vendor/bin/phpunit tests/Integration/Database $(find tests/Integration -path 'tests/Integration/*/Database/MySql' -type d)
Comment thread
coderabbitai[bot] marked this conversation as resolved.

mysql_9:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
DB_DATABASE: testing
DB_USERNAME: root
DB_PASSWORD: password
run: vendor/bin/phpunit tests/Integration/Database
run: vendor/bin/phpunit tests/Integration/Database $(find tests/Integration -path 'tests/Integration/*/Database/MySql' -type d)

mariadb_10:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -174,7 +174,7 @@ jobs:
DB_DATABASE: testing
DB_USERNAME: root
DB_PASSWORD: password
run: vendor/bin/phpunit tests/Integration/Database
run: vendor/bin/phpunit tests/Integration/Database $(find tests/Integration -path 'tests/Integration/*/Database/MariaDb' -type d)

mariadb_11:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -230,7 +230,7 @@ jobs:
DB_DATABASE: testing
DB_USERNAME: root
DB_PASSWORD: password
run: vendor/bin/phpunit tests/Integration/Database
run: vendor/bin/phpunit tests/Integration/Database $(find tests/Integration -path 'tests/Integration/*/Database/MariaDb' -type d)

pgsql_17:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -286,7 +286,7 @@ jobs:
DB_DATABASE: testing
DB_USERNAME: postgres
DB_PASSWORD: password
run: vendor/bin/phpunit tests/Integration/Database
run: vendor/bin/phpunit tests/Integration/Database $(find tests/Integration -path 'tests/Integration/*/Database/Postgres' -type d)

pgsql_18:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -342,7 +342,7 @@ jobs:
DB_DATABASE: testing
DB_USERNAME: postgres
DB_PASSWORD: password
run: vendor/bin/phpunit tests/Integration/Database
run: vendor/bin/phpunit tests/Integration/Database $(find tests/Integration -path 'tests/Integration/*/Database/Postgres' -type d)

sqlite:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -382,4 +382,4 @@ jobs:
DB_DATABASE: /tmp/testing.sqlite
run: |
touch /tmp/testing.sqlite
vendor/bin/phpunit tests/Integration/Database
vendor/bin/phpunit tests/Integration/Database $(find tests/Integration -path 'tests/Integration/*/Database/Sqlite' -type d)
Loading