Skip to content

Fix some clang warnings. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmcarcell merged 2 commits into from
Jul 11, 2026
+14 −1
Merged

Fix some clang warnings. #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
837b8fd
Fix some clang warnings.
Oct 16, 2025
3730c9e
Apply Rule of Five: add move ctors/assign and uncomment copy assign
jmcarcell Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/geomlib/THelicalTrack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ class THelicalTrack : public TVTrack {
Double_t b,
const TTrackFrame &frame);

THelicalTrack(const THelicalTrack&) = default;
THelicalTrack& operator=(const THelicalTrack&) = default;
THelicalTrack(THelicalTrack&&) = default;
THelicalTrack& operator=(THelicalTrack&&) = default;

virtual ~THelicalTrack() {}

// Utility methods
Expand Down
5 changes: 5 additions & 0 deletions src/geomlib/TVTrack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ class TVTrack : public TVCurve {
Double_t b,
const TTrackFrame &f);

TVTrack(const TVTrack&) = default;
TVTrack& operator=(const TVTrack&) = default;
TVTrack(TVTrack&&) = default;
TVTrack& operator=(TVTrack&&) = default;

virtual ~TVTrack() {}

// Utility methods
Expand Down
5 changes: 4 additions & 1 deletion src/kaltracklib/TTrackFrame.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,14 @@ class TTrackFrame {
//Copy constructor
TTrackFrame(const TTrackFrame &orig);

TTrackFrame(TTrackFrame&&) = default;
TTrackFrame& operator=(TTrackFrame&&) = default;

//Build frame by last frame, shift vector and B field. The B field determines local
//rotation matrix.
TTrackFrame(const TTrackFrame &lastFrame, const TVector3 &v, const TVector3 &b);

//TTrackFrame& operator=( const TTrackFrame& frame );
TTrackFrame& operator=(const TTrackFrame& frame) = default;

virtual ~TTrackFrame() {}

Expand Down
Loading