Skip to content

IBX-11949: Added content language context extension point#1945

Open
mikadamczyk wants to merge 1 commit into
4.6from
IBX-11949-language-context-resolver
Open

IBX-11949: Added content language context extension point#1945
mikadamczyk wants to merge 1 commit into
4.6from
IBX-11949-language-context-resolver

Conversation

@mikadamczyk

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-11949

Description:

Adds a content language context extension point in admin-ui and makes it the owner of the normalized back-office request attribute contentLanguageCode. admin-ui now exposes the public contract through ContentLanguageContext::ATTRIBUTE_NAME, resolves the language code through a tagged resolver chain, and stores the normalized value on the request in NormalizedLanguageCodeListener.

This removes package-specific request parsing from connector-ai and lets packages that already depend on admin-ui extend language context resolution without changing connector-ai itself. page-builder can register a resolver that reads request_block_configuration['language'], while connector-ai only reads Request::attributes[ContentLanguageContext::ATTRIBUTE_NAME].

For QA:

Documentation:

@mikadamczyk mikadamczyk self-assigned this Jun 19, 2026
@mikadamczyk mikadamczyk requested a review from a team June 19, 2026 13:03
@ibexa-workflow-automation-1 ibexa-workflow-automation-1 Bot requested review from Steveb-p, ViniTou, alongosz, barw4, bnowak, ciastektk, konradoboza, tbialcz and wiewiurdp and removed request for a team June 19, 2026 13:03
Comment thread tests/lib/Request/Resolver/AdminUiContentLanguageCodeResolverTest.php Outdated
Comment thread tests/lib/Request/Resolver/AdminUiContentLanguageCodeResolverTest.php Outdated

@konradoboza konradoboza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But Andrew made some valid comments.

Comment thread src/lib/EventListener/NormalizedLanguageCodeListener.php Outdated
Comment thread src/lib/Request/Resolver/ChainContentLanguageCodeResolver.php Outdated
@mikadamczyk mikadamczyk force-pushed the IBX-11949-language-context-resolver branch from 01c068d to 9e548c7 Compare June 22, 2026 08:23
@sonarqubecloud

Copy link
Copy Markdown

@mikadamczyk mikadamczyk requested a review from alongosz June 22, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants