IBX-11848: Fixed filtering by content types in ibexa:reindex command#760
Conversation
…able for anonymous
alongosz
left a comment
alongosz
left a comment
There was a problem hiding this comment.
@vidarl looks like CI failure is relevant to the changes, at least when it comes to Solr integration tests.
…t available for anonymous
vidarl
force-pushed
the
IBX-11848_reindex_by_content-type_will_only_index_content_available_for_anonymous
branch
from
34ed618 to
ab30bb7
Compare
| */ | ||
| protected function supportsLikeWildcard($value) | ||
| { | ||
| parent::supportsLikeWildcard($value); |
There was a problem hiding this comment.
In 7129d21, parent::supportsLikeWildcard() read:
protected function supportsLikeWildcard($value)
{
if ($this->getSetupFactory() instanceof LegacyElasticsearch) {
$this->markTestSkipped('Elasticsearch Search Engine does not support Field Criterion LIKE');
}
return !is_numeric($value) && !is_bool($value);
}
However, now it only returns the return. Thus it should be safe to remove the call to parent::supportsLikeWildcard()
|
@alongosz : Fixed that now, and also non-releated PHPStan complains |
alongosz
changed the title
ibexa:reindex command
alongosz
requested review from
Steveb-p,
ViniTou,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
|
|
||
| return $this->contentService->find($filter); | ||
| /** @var \Ibexa\Contracts\Core\Repository\Values\Content\ContentList $contentList */ | ||
| $contentList = $this->repository->sudo(function () use ($filter) { |
There was a problem hiding this comment.
Strict type is missing in a closure
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
Apart from Bartek's comment.
7 participants
Description:
The
--content-typeparameter foribexa:reindexwill execute a filter search (ContentService::find()), and this only returns content that is available to current user ( script is running asanonymous)For QA:
Instructions on how to reproduce is provided in ticket description
Documentation: