Add async support using separate files (non-breaking)#151
Draft
johanzander wants to merge 2 commits into
Draft
Conversation
Non-breaking addition of async API classes using the separate-files pattern (similar to the OpenAI SDK). Sync code remains untouched on requests; async classes use httpx as an optional dependency. New files: - async_base_api.py: AsyncGrowattApi (async copy of GrowattApi) - open_api_v1/async_open_api_v1.py: AsyncOpenApiV1 - open_api_v1/devices/async_min.py: AsyncMin - open_api_v1/devices/async_sph.py: AsyncSph Install with: pip install growattServer[async] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add noqa: PLC0415 for lazy imports inside __getattr__ - Extract f-string from AttributeError to variable (EM102) - Remove unused noqa: S324 directive from async_base_api.py Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestsremains the sync HTTP libraryhttpxas an optional dependency (pip install growattServer[async])__getattr__sohttpxis never required unless async classes are usedNew files
growattServer/async_base_api.pyAsyncGrowattApiGrowattApigrowattServer/open_api_v1/async_open_api_v1.pyAsyncOpenApiV1OpenApiV1growattServer/open_api_v1/devices/async_min.pyAsyncMinMingrowattServer/open_api_v1/devices/async_sph.pyAsyncSphSphUsage
Trade-offs vs #150
This is an alternative to #150 for discussion on #149. The main advantage is that it is non-breaking — existing consumers (including Home Assistant) continue to work without any changes.
Test plan
AsyncGrowattApiandAsyncOpenApiV1instantiate correctlyget_device()returnsAsyncMin/AsyncSphcorrectly🤖 Generated with Claude Code