ci(helm): migrated charts to this repository instead#2211
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Boutique and TestNet Wallet Helm charts into the interledger/testnet monorepo and adds GitHub Actions workflows to validate charts on PRs and publish packaged charts to the charts branch (GitHub Pages) on releases.
Changes:
- Adds two Helm charts under
helm/(boutique,testnet-wallet) using the sharedcommonchart helpers. - Adds
helm-unittestsuites to validate services, deployments, configmaps, and secrets behavior. - Introduces CI workflows for chart linting/testing/rendering on PRs and chart packaging/index publishing on release.
Reviewed changes
Copilot reviewed 31 out of 33 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| helm/testnet-wallet/values.yaml | Default values and env/config/secrets mappings for the wallet chart. |
| helm/testnet-wallet/tests/services_test.yaml | helm-unittest coverage for wallet Services. |
| helm/testnet-wallet/tests/secrets_test.yaml | helm-unittest coverage for wallet Secret creation behavior. |
| helm/testnet-wallet/tests/deployment.frontend_test.yaml | helm-unittest coverage for wallet frontend Deployment rendering. |
| helm/testnet-wallet/tests/deployment.backend_test.yaml | helm-unittest coverage for wallet backend Deployment rendering. |
| helm/testnet-wallet/templates/service.frontend.yaml | Wallet frontend Service template delegating to common.svc. |
| helm/testnet-wallet/templates/service.backend.yaml | Wallet backend Service template delegating to common.svc. |
| helm/testnet-wallet/templates/secrets.backend.yaml | Wallet backend Secrets template delegating to common.secretMapper. |
| helm/testnet-wallet/templates/deployment.frontend.yaml | Wallet frontend Deployment template with configmap hash annotation. |
| helm/testnet-wallet/templates/deployment.backend.yaml | Wallet backend Deployment template with configmap hash annotation. |
| helm/testnet-wallet/templates/configMap.frontend.yaml | Wallet frontend ConfigMap template delegating to common.configMapper. |
| helm/testnet-wallet/templates/configMap.backend.yaml | Wallet backend ConfigMap template delegating to common.configMapper. |
| helm/testnet-wallet/README.md | Usage and configuration documentation for the wallet chart. |
| helm/testnet-wallet/Chart.yaml | Chart metadata + dependency on common. |
| helm/testnet-wallet/Chart.lock | Locked dependency resolution for common. |
| helm/boutique/values.yaml | Default values and env/config/secrets mappings for the boutique chart. |
| helm/boutique/tests/services_test.yaml | helm-unittest coverage for boutique Services. |
| helm/boutique/tests/secrets_test.yaml | helm-unittest coverage for boutique Secret creation behavior. |
| helm/boutique/tests/deployment.frontend_test.yaml | helm-unittest coverage for boutique frontend Deployment/ConfigMap rendering. |
| helm/boutique/tests/deployment.backend_test.yaml | helm-unittest coverage for boutique backend Deployment/ConfigMap rendering. |
| helm/boutique/templates/service.frontend.yaml | Boutique frontend Service template delegating to common.svc. |
| helm/boutique/templates/service.backend.yaml | Boutique backend Service template delegating to common.svc. |
| helm/boutique/templates/secrets.backend.yaml | Boutique backend Secrets template delegating to common.secretMapper. |
| helm/boutique/templates/deployment.frontend.yaml | Boutique frontend Deployment template with configmap hash annotation. |
| helm/boutique/templates/deployment.backend.yaml | Boutique backend Deployment template with configmap hash annotation. |
| helm/boutique/templates/configMap.frontend.yaml | Boutique frontend ConfigMap template delegating to common.configMapper. |
| helm/boutique/templates/configMap.backend.yaml | Boutique backend ConfigMap template delegating to common.configMapper. |
| helm/boutique/README.md | Usage and configuration documentation for the boutique chart. |
| helm/boutique/Chart.yaml | Chart metadata + dependency on common. |
| helm/boutique/Chart.lock | Locked dependency resolution for common. |
| .github/workflows/helm-publish.yml | Packages and publishes charts to the charts branch on release. |
| .github/workflows/helm-charts.yml | Runs helm dependency update, helm lint, helm unittest, and helm template on PRs touching helm/**. |
| .github/copilot-instructions.md | Documents Helm chart structure and CI/publishing workflows in repo guidance. |
Comments suppressed due to low confidence (1)
helm/boutique/tests/deployment.frontend_test.yaml:46
- The frontend ConfigMap test expectations don’t match
helm/boutique/values.yaml: the chart setsAPI_BASE_URLfromconfig.frontend.apiBaseUrl(defaulthttps://boutique.example.com) and does not define aPORTkey for the frontend ConfigMap. This test will fail against the current chart.
- it: 'should create configmap with correct environment variables'
template: configMap.frontend.yaml
asserts:
- equal:
path: metadata.name
value: test-rafiki-boutique-frontend
- equal:
path: data.API_BASE_URL
value: "https://boutique.example.com"
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
dragosp1011
approved these changes
Jun 18, 2026
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to streamline the development process, and making it easier to verify if developers remembered to update the helm charts, we are now migrating the relevant helm charts to the testnet mono repository. This will allow us to use LLM and other tools to detect problems introduced earlier in the development life cycle.
This PR migrates the helm charts to here, and introduces pipelines to facilitate testing and publishing of the charts using Github Pages.