Bump esbuild, @actions/core, and undici to fix vulnerabilities - #32
Merged
Conversation
Upgrades esbuild to 0.28.1 and @actions/core to 3.0.1, and pins undici (transitive via @actions/http-client) to 6.27.0 via an override since the core bump alone didn't resolve it past the vulnerable range. Regenerates package-lock.json and build/main.cjs. Closes ispc#28, ispc#29, ispc#30, ispc#31. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the action’s Node.js dependency set to address reported vulnerabilities, and regenerates the lockfile and bundled build/main.cjs artifact used at runtime by the GitHub Action.
Changes:
- Bumped
@actions/coreto^3.0.1andesbuildto^0.28.1. - Added an npm
overridesentry to forceundicito^6.27.0, and regeneratedpackage-lock.json. - Rebuilt the bundled action entrypoint (
build/main.cjs) to reflect the updated dependency tree.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates direct deps and adds an overrides rule for undici. |
| package-lock.json | Lockfile regeneration reflecting updated versions and the undici override. |
| build/main.cjs | Regenerated bundled runtime artifact containing updated vendored dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Per review feedback: a caret range still permits automatic upgrades, undermining the intent of pinning undici for reproducibility. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esbuild(devDependency) 0.27.2 → 0.28.1 — fixes local dev-server path traversal and adds Deno API integrity checks.@actions/core2.0.3 → 3.0.1.undici(via@actions/http-client) to 6.27.0, since the@actions/corebump alone left it at 6.24.1 — addresses WebSocket DoS, Set-Cookie header injection, and keep-alive queue poisoning advisories.package-lock.jsonandbuild/main.cjs.Closes #28, #29, #30, #31.
Test plan
npm auditreports 0 vulnerabilities after the override@actions/corenamed exports (addPath,setFailed,getInput) still resolvenpm run buildsucceeds,node --check build/main.cjspasses🤖 Generated with Claude Code