Simplify video test fixtures#7
Open
mmkal wants to merge 3 commits into
Open
Conversation
commit: |
mmkal
marked this pull request as ready for review
July 24, 2026 14:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Video fixtures now keep only styles that the tests measure.
Presentation CSS such as cards, typography, spacing, and decorative layouts is gone. Geometry, visibility, and state colors remain inline where frame analysis or cursor detection depends on them.
This removes 304 lines from the video specs without changing video-mode runtime behavior or public APIs.
Videos
Playwright steps remain useful captions with browser-default fixture styling:
video-rendered.webm
Dead-air compression, holds, cursor movement, and post-rendered highlights still read clearly:
video-rendered.webm
Synthetic dialog rendering and its pointer click still preserve the measured visual state:
video-rendered.webm
Validation
pnpm exec playwright test spec/video-mode.spec.ts spec/video-mode-auto-start.spec.ts spec/video-mode-ffmpeg.spec.ts— 40 passedpnpm test— 74 passed, 3 skippedpnpm typecheckpnpm buildpnpm exec publintNote
Low Risk
Test-only fixture markup changes with no production or API surface touched; behavior preserved per passing video specs.
Overview
Strips presentation-only CSS from video-related Playwright specs (
video-mode-auto-start,video-mode-ffmpeg,video-mode) so fixtures read like tests, not mini apps.<style>blocks are removed (~304 lines); decorative layout, typography, and card chrome go away.Assertion-critical styling stays as minimal one-line
styleattributes or script-driven updates: colors and geometry for pixel/frame analysis, visibility (hiddeninstead ofdisplay/visibilitytoggles where appropriate), spinner/disabled state colors, and blank→content startup fixtures (e.g. a single red panel instead of four quadrants).No changes to
videoModeruntime, public APIs, or test timing/viewport/assertion intent; a completed task note documents validation (focused + full suite).Reviewed by Cursor Bugbot for commit 2c637b7. Bugbot is set up for automated code reviews on this repo. Configure here.