Type short fills in video mode#8
Draft
mmkal wants to merge 4 commits into
Draft
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
videoMode()now shows shortlocator.fill()values arriving character by character.Non-empty values up to 100 characters are cleared, then typed with a 50 ms delay per character. Empty, longer, and forced fills keep Playwright's original action. Highlights and metadata still describe the caller's
fill().The renderer uses the real field pixels from the typed action over its stable pre-action frame. This keeps the text animation without replaying unrelated page effects.
Before
The email field stays empty for the text hold, then jumps to the complete value.
before-instant-fill.webm
After
The same unchanged test now shows
ada@example.comarriving character by character.after-typed-fill.webm
Validation
typeFills: falsepublintpassedCodex session:
019f947f-ca3b-7ed0-ab92-e637bf51e01a