dtype-aware tendency values#175
Open
DaanVanVugt wants to merge 4 commits into
Open
Conversation
DaanVanVugt
requested review from
MireilleSchneider,
SBlokhuizen and
maarten-ic
as code owners
DaanVanVugt
force-pushed
the
tendency-value-dtype
branch
from
12044d8 to
9c34ca1
Compare
Open
SBlokhuizen
reviewed
Jun 25, 2026
SBlokhuizen
left a comment
SBlokhuizen
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good to me! Can you update the docs of the constant tendency?
SBlokhuizen
reviewed
Jun 25, 2026
- Rename is_string -> is_categorical so booleans are treated like strings (held as a zero-order-hold step rather than coerced to float and interpolated) - Reject mixing categorical (string/boolean) and numeric values within a single waveform, since the gaps between them cannot be interpolated - Document the constant tendency value types (float/int/categorical) in the docs
np.full preserved int dtype for integer constants, so get_value() (the time=None path) returned an int64 array while the explicit-time path upcast to float. Force float for numeric values; categorical values (str/bool) keep their native dtype.
mikesndrs
approved these changes
Jul 10, 2026
DaanVanVugt
force-pushed
the
tendency-value-dtype
branch
from
4ca49ac to
fc48600
Compare
SBlokhuizen
requested changes
Jul 14, 2026
| tendency.resolver = resolver | ||
| tendency.default_path = self.name | ||
|
|
||
| @property |
Collaborator
There was a problem hiding this comment.
Should we check whether the specific dtype is valid for the specific IDS node e.g. during exporting?
Comment on lines
+22
to
+28
| @property | ||
| def is_categorical(self): | ||
| """Whether this constant holds a non-numeric (categorical) value, e.g. a | ||
| string or boolean, that is held as a step rather than interpolated.""" | ||
| value = self.value | ||
| return isinstance(value, bool) or not isinstance(value, (int, float)) | ||
|
|
Collaborator
There was a problem hiding this comment.
Screencast.From.2026-07-14.14-53-38.mp4
Reloading a string waveform YAML snippet does not work for the panel editor, could you have a look at that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.