feat(flow): SGCR is now the default engine for ungrouped graphs (Phase 4/6) - #291
Merged
Conversation
Flip the engine gate: ungrouped flows now render through SgcrFlowInner (provable orthogonal-polyline edges, content-sized nodes, viewport-aware spacing) instead of FlowInner (dagre smoothstep). `engine:"dagre"` opts out. Grouped graphs still use FlowInner (zone containers + parentId + smoothstep are dagre-path infrastructure) but their INTRA-zone layout is already SGCR from Phase 3. This means the 3 ungrouped live boards (pr676-warning-signal, escape-room, chest-anim) immediately get SGCR's tight, overlap-free layout with no spec changes. New pushes without an explicit `engine` field also get SGCR. 728 viewer tests pass. tsc strict clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flip the gate:
spec.engine !== "dagre" && !grouped. Ungrouped flows now render through SgcrFlowInner (provable layout, viewport-aware spacing, orthogonal edges).engine:"dagre"opts out. Grouped flows still use FlowInner but with SGCR intra-zone layout (Phase 3). 728 tests, tsc clean.