viewer/framing-lint: places-single-image rule — enforce multi-image carousels - #296
Draft
ivanmkc wants to merge 1 commit into
Draft
viewer/framing-lint: places-single-image rule — enforce multi-image carousels#296ivanmkc wants to merge 1 commit into
ivanmkc wants to merge 1 commit into
Conversation
…arousels
Place cards rendering ONE bare Image (or a 1-image ImageCarousel) now warn
at push time: Places photos come 4-at-a-time, so a single image means the
fetch stopped early. Complements places-no-image; same non-blocking
{warnings,findings} contract. 3 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Place cards that render a single bare Image (or a 1-image ImageCarousel) now get a push-time warning steering toward multi-image ImageCarousels. Complements the places-no-image rule it stacks on; non-blocking, same findings contract, 3 tests (32/32 green).