fix(#298): add go install instructions to bundled notion-cli plugin - #372
fix(#298): add go install instructions to bundled notion-cli plugin#372javimosch wants to merge 1 commit into
Conversation
Adds the primary `go install github.com/4ier/notion-cli@latest` installation path and explains how to symlink/rename the resulting `notion-cli` binary as `notion` so the plugin's `which notion` check and all commands work. Fixes #298 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughThe Notion CLI guidance now uses Go installation with a ChangesNotion CLI installation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/notion-cli/install-guidance.json`:
- Around line 6-8: Ensure the installed notion binary remains discoverable
through PATH by adding persistent PATH setup or linking it into an existing PATH
directory. Apply the same setup to plugins/notion-cli/install-guidance.json
lines 6-8, plugins/notion-cli/plugin.json lines 14-15, and
plugins/notion-cli/skills/quickstart/SKILL.md lines 61-66 before the notion
--version verification.
In `@plugins/notion-cli/plugin.json`:
- Around line 14-15: Update the installation guidance in the plugin manifest
around the notion-cli install and symlink commands to explicitly add the
resolved Go binary directory to PATH, ensuring the installed notion executable
can be found by subsequent PATH-based checks and invocations.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 67201da5-526b-481e-87a5-67567e8afc7d
📒 Files selected for processing (3)
plugins/notion-cli/install-guidance.jsonplugins/notion-cli/plugin.jsonplugins/notion-cli/skills/quickstart/SKILL.md
| "go install github.com/4ier/notion-cli@latest", | ||
| "GOBIN=$(go env GOBIN); GOPATH=$(go env GOPATH); ln -sf \"${GOBIN:-$GOPATH/bin}/notion-cli\" \"${GOBIN:-$GOPATH/bin}/notion\"", | ||
| "Verify: notion --version", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Keep the installed notion binary on PATH.
The installation steps place the binary in the Go binary directory, but the plugin checks and launches notion through PATH.
plugins/notion-cli/install-guidance.json#L6-L8: add persistentPATHsetup or link into an existingPATHdirectory.plugins/notion-cli/plugin.json#L14-L15: include the same setup in manifest guidance.plugins/notion-cli/skills/quickstart/SKILL.md#L61-L66: add the setup beforenotion --version.
📍 Affects 3 files
plugins/notion-cli/install-guidance.json#L6-L8(this comment)plugins/notion-cli/plugin.json#L14-L15plugins/notion-cli/skills/quickstart/SKILL.md#L61-L66
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/notion-cli/install-guidance.json` around lines 6 - 8, Ensure the
installed notion binary remains discoverable through PATH by adding persistent
PATH setup or linking it into an existing PATH directory. Apply the same setup
to plugins/notion-cli/install-guidance.json lines 6-8,
plugins/notion-cli/plugin.json lines 14-15, and
plugins/notion-cli/skills/quickstart/SKILL.md lines 61-66 before the notion
--version verification.
| "go install github.com/4ier/notion-cli@latest", | ||
| "GOBIN=$(go env GOBIN); GOPATH=$(go env GOPATH); ln -sf \"${GOBIN:-$GOPATH/bin}/notion-cli\" \"${GOBIN:-$GOPATH/bin}/notion\"", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Keep the installed binary on PATH.
Line 15 creates the symlink in the Go binary directory, but the manifest only checks and executes notion through PATH. Include the PATH setup in this manifest guidance.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/notion-cli/plugin.json` around lines 14 - 15, Update the installation
guidance in the plugin manifest around the notion-cli install and symlink
commands to explicitly add the resolved Go binary directory to PATH, ensuring
the installed notion executable can be found by subsequent PATH-based checks and
invocations.
|
🤖 Escalated to CEO: https://github.com/javimosch/am-fleet/issues/45 The rebaser could not resolve conflicts automatically. Reply on the issue above to unblock this PR. |
Automated maintenance run by automaintainer.
Focus: == ASSIGNED OBJECTIVE ==
Fix GitHub issue #298 ONLY: Add 4ier/notion-cli as a bundled plugin in SuperCLI. PR title MUST reference #298.
OPEN PR AWARENESS (secondary — do not replace the ASSIGNED OBJECTIVE):
These open pull requests are already open and awaiting review. Do NOT start UNRELATED work on the files they touch. If your ASSIGNED OBJECTIVE requires editing one of those files, complete the objective anyway. Never abandon the objective to pick a different GitHub issue just to avoid overlap.
touches: plugins/notion-cli/install-guidance.json, plugins/notion-cli/plugin.json, plugins/notion-cli/skills/quickstart/SKILL.md
touches: plugins/notion-cli/install-guidance.json, plugins/notion-cli/plugin.json, plugins/notion-cli/skills/quickstart/SKILL.md
touches: plugins/notion-cli/install-guidance.json, plugins/notion-cli/plugin.json, plugins/notion-cli/skills/quickstart/SKILL.md
run <plugin> <resource> <action>one-shot command #365 (am/am-f17c27-dkdoeotqzvn8-3120cd1a): fix(feat:sc run <plugin> <action>— one-shot discover+install+execute #335): implementrun <plugin> <resource> <action>one-shot commandtouches: tests/run-command.test.js, cli/help-json.js, cli/help.js, cli/run.js, cli/supercli.js
touches: .github/workflows/sc-machin-release.yml, README.md, supercli-machin-cli/README.md, supercli-machin-cli/install.sh
Branch:
am/am-f17c27-dkg9sc8fjw7x-91e45236Diff:
Summary by CodeRabbit