Skip to content

fix(#298): add go install instructions to bundled notion-cli plugin - #372

Open
javimosch wants to merge 1 commit into
masterfrom
am/am-f17c27-dkg9sc8fjw7x-91e45236
Open

fix(#298): add go install instructions to bundled notion-cli plugin#372
javimosch wants to merge 1 commit into
masterfrom
am/am-f17c27-dkg9sc8fjw7x-91e45236

Conversation

@javimosch

@javimosch javimosch commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Automated maintenance run by automaintainer.

Focus: == ASSIGNED OBJECTIVE ==
Fix GitHub issue #298 ONLY: Add 4ier/notion-cli as a bundled plugin in SuperCLI. PR title MUST reference #298.


OPEN PR AWARENESS (secondary — do not replace the ASSIGNED OBJECTIVE):
These open pull requests are already open and awaiting review. Do NOT start UNRELATED work on the files they touch. If your ASSIGNED OBJECTIVE requires editing one of those files, complete the objective anyway. Never abandon the objective to pick a different GitHub issue just to avoid overlap.

Branch: am/am-f17c27-dkg9sc8fjw7x-91e45236

Diff:

plugins/notion-cli/install-guidance.json      |  5 +++--
 plugins/notion-cli/plugin.json                |  7 ++++---
 plugins/notion-cli/skills/quickstart/SKILL.md | 17 ++++++++++++++++-
 3 files changed, 23 insertions(+), 6 deletions(-)

Summary by CodeRabbit

  • Documentation
    • Updated Notion CLI installation guidance to prioritize Go installation with the required binary symlink.
    • Added npm installation instructions.
    • Clarified Homebrew, Scoop, and GitHub Releases as alternative installation methods.
    • Improved version, command passthrough, and authentication guidance.

Adds the primary `go install github.com/4ier/notion-cli@latest`
installation path and explains how to symlink/rename the resulting
`notion-cli` binary as `notion` so the plugin's `which notion` check
and all commands work.

Fixes #298

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Notion CLI guidance now uses Go installation with a notion-cli to notion symlink as the primary path. It also documents Homebrew, npm, Scoop, and GitHub Releases alternatives and updates dependency help messages.

Changes

Notion CLI installation

Layer / File(s) Summary
Installation methods
plugins/notion-cli/install-guidance.json, plugins/notion-cli/plugin.json, plugins/notion-cli/skills/quickstart/SKILL.md
The guidance adds go install and symlink setup. It retains Homebrew and adds npm, Scoop, and GitHub Releases options.
Dependency and command guidance
plugins/notion-cli/plugin.json
Version and passthrough command messages explain the notion-cli binary name, symlink or rename steps, and authentication instructions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • javimosch/supercli#298: This issue concerns the bundled Notion CLI plugin and its Go-based installation.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding Go installation instructions for the bundled notion-cli plugin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch am/am-f17c27-dkg9sc8fjw7x-91e45236

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/notion-cli/install-guidance.json`:
- Around line 6-8: Ensure the installed notion binary remains discoverable
through PATH by adding persistent PATH setup or linking it into an existing PATH
directory. Apply the same setup to plugins/notion-cli/install-guidance.json
lines 6-8, plugins/notion-cli/plugin.json lines 14-15, and
plugins/notion-cli/skills/quickstart/SKILL.md lines 61-66 before the notion
--version verification.

In `@plugins/notion-cli/plugin.json`:
- Around line 14-15: Update the installation guidance in the plugin manifest
around the notion-cli install and symlink commands to explicitly add the
resolved Go binary directory to PATH, ensuring the installed notion executable
can be found by subsequent PATH-based checks and invocations.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 67201da5-526b-481e-87a5-67567e8afc7d

📥 Commits

Reviewing files that changed from the base of the PR and between 6df5369 and 395c541.

📒 Files selected for processing (3)
  • plugins/notion-cli/install-guidance.json
  • plugins/notion-cli/plugin.json
  • plugins/notion-cli/skills/quickstart/SKILL.md

Comment on lines +6 to 8
"go install github.com/4ier/notion-cli@latest",
"GOBIN=$(go env GOBIN); GOPATH=$(go env GOPATH); ln -sf \"${GOBIN:-$GOPATH/bin}/notion-cli\" \"${GOBIN:-$GOPATH/bin}/notion\"",
"Verify: notion --version",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Keep the installed notion binary on PATH.

The installation steps place the binary in the Go binary directory, but the plugin checks and launches notion through PATH.

  • plugins/notion-cli/install-guidance.json#L6-L8: add persistent PATH setup or link into an existing PATH directory.
  • plugins/notion-cli/plugin.json#L14-L15: include the same setup in manifest guidance.
  • plugins/notion-cli/skills/quickstart/SKILL.md#L61-L66: add the setup before notion --version.
📍 Affects 3 files
  • plugins/notion-cli/install-guidance.json#L6-L8 (this comment)
  • plugins/notion-cli/plugin.json#L14-L15
  • plugins/notion-cli/skills/quickstart/SKILL.md#L61-L66
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@plugins/notion-cli/install-guidance.json` around lines 6 - 8, Ensure the
installed notion binary remains discoverable through PATH by adding persistent
PATH setup or linking it into an existing PATH directory. Apply the same setup
to plugins/notion-cli/install-guidance.json lines 6-8,
plugins/notion-cli/plugin.json lines 14-15, and
plugins/notion-cli/skills/quickstart/SKILL.md lines 61-66 before the notion
--version verification.

Comment on lines +14 to +15
"go install github.com/4ier/notion-cli@latest",
"GOBIN=$(go env GOBIN); GOPATH=$(go env GOPATH); ln -sf \"${GOBIN:-$GOPATH/bin}/notion-cli\" \"${GOBIN:-$GOPATH/bin}/notion\"",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Keep the installed binary on PATH.

Line 15 creates the symlink in the Go binary directory, but the manifest only checks and executes notion through PATH. Include the PATH setup in this manifest guidance.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@plugins/notion-cli/plugin.json` around lines 14 - 15, Update the installation
guidance in the plugin manifest around the notion-cli install and symlink
commands to explicitly add the resolved Go binary directory to PATH, ensuring
the installed notion executable can be found by subsequent PATH-based checks and
invocations.

@javimosch

Copy link
Copy Markdown
Owner Author

🤖 Escalated to CEO: https://github.com/javimosch/am-fleet/issues/45

The rebaser could not resolve conflicts automatically. Reply on the issue above to unblock this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant