fix(lint): benchmark output is not this project's source - #13
Merged
Conversation
`eslint .` reported 861 errors on a clean checkout of `main`, every one of them from `.ignore/` — the scratch tree where benchmark runs leave the todo apps the agent built. Vite configs and React hooks parsed as CommonJS, plus 845 from one minified `dist/` bundle. None of it is authored here, and none of it says anything about HirayaCoder. `npm run lint` never saw it because that script names `app test`, so CI stayed green while anyone running the linter directly — or just opening the repo with the ESLint extension, which lints the whole workspace — saw a repository that looked broken. `.ignore/` now sits with the other generated trees the config already skips. It is the same set `.gitignore` refuses to track, for the same reason. `npm run lint` is unchanged at 0 errors; `eslint .` now exits clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint .reported 861 errors on a clean checkout ofmain, every one of them from.ignore/— the scratch tree where benchmark runs leave the todo apps the agent built. Vite configs and React hooks parsed as CommonJS, plus 845 from one minifieddist/bundle.None of it is authored here, and none of it says anything about HirayaCoder.
npm run lintnever saw it because that script namesapp test, so CI stayed green while anyone running the linter directly — or just opening the repo with the ESLint extension, which lints the whole workspace — saw a repository that looked broken..ignore/now sits with the other generated trees the config already skips. It is the same set.gitignorerefuses to track, for the same reason.npm run lintis unchanged at 0 errors;eslint .now exits clean.