feat/fix: support literal and single-quoted style for YAML::Binary emitting#1447
Open
sxrzh wants to merge 2 commits into
Open
feat/fix: support literal and single-quoted style for YAML::Binary emitting#1447sxrzh wants to merge 2 commits into
sxrzh wants to merge 2 commits into
Conversation
Author
|
I also implemented the line wrapping as mentioned in #1287, should I commit it here or open another PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1445 and a part of issue #1287.
Support literal and single-quoted style for YAML::Binary emitting. Attempts to support plain form may change the default behavior, so are not applied.
Related tests are added to
EmitterTest.BinaryStylesin test/integration/emitter_test.cpp.