Skip to content

Release: Bump version in package-lock.json as well during the release - #603

Merged
mgol merged 4 commits into
jquery:mainfrom
mgol:release-lockfile-version
Jan 12, 2026
Merged

Release: Bump version in package-lock.json as well during the release#603
mgol merged 4 commits into
jquery:mainfrom
mgol:release-lockfile-version

Conversation

@mgol

@mgol mgol commented Sep 23, 2025

Copy link
Copy Markdown
Member

No description provided.

@mgol mgol self-assigned this Sep 23, 2025
@mgol mgol added this to the 4.0.0 milestone Sep 23, 2025
@timmywil

Copy link
Copy Markdown
Member

Same note as jquery/jquery-release#119. I'd prefer we make npm do this.

@mgol

mgol commented Oct 13, 2025

Copy link
Copy Markdown
Member Author

@timmywil

Copy link
Copy Markdown
Member

Please add Needs Review back when updated.

@mgol
mgol force-pushed the release-lockfile-version branch from 35fad55 to 6e0a335 Compare December 19, 2025 10:00
@mgol
mgol requested a review from timmywil January 12, 2026 18:12
@mgol

mgol commented Jan 12, 2026

Copy link
Copy Markdown
Member Author

@timmywil I added a few fixup commits to fix edge cases (not all related to what this PR does, but important for 4.0.0) and it worked fine in the dry-run & remote modes.

I do wish we had release-it here, but that's for the future. PTAL.

@mgol
mgol merged commit c29e540 into jquery:main Jan 12, 2026
14 checks passed
@mgol
mgol deleted the release-lockfile-version branch January 12, 2026 19:07
@mgol mgol removed the Needs review label Jan 12, 2026
mgol added a commit that referenced this pull request Jan 12, 2026
Also:
* make argument parsing more resilient to different orders
* catch pre-release versions when updating README
* die on unrecognized parameters

Closes gh-603

(cherry picked from commit c29e540)
@mgol mgol modified the milestones: 4.0.0, 3.6.1 Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants