fix(ftp): upload postshow episodes into FTP_POSTSHOW_DIR#32
Open
k0te1ch wants to merge 1 commit into
Open
Conversation
The SFTP publisher read FTP_POSTSHOW_DIR but never used it, so every file landed in the home directory regardless of episode type. Aftershow episodes were meant to go into a dedicated subfolder. Route postshow uploads into FTP_POSTSHOW_DIR (creating it if missing) and keep main episodes at the root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Aftershow (postshow) episodes were uploading to the FTP root instead of their dedicated subfolder.
Why
The SFTP publisher read
FTP_POSTSHOW_DIRfrom config but never applied it —sftp.open(file_name, ...)always wrote to the home directory regardless of episode type. Meanwhile the episode-number lookup (get_last_post_ID) doescwdintopostshow, so the next number was computed from one folder while the file landed in another. That mismatch is what showed up as "the mp3 went to the wrong folder".What changed
_remote_path()routes postshow episodes intoFTP_POSTSHOW_DIR, main episodes stay at root.aftershow(UI/state alias) andpostshow(canonical) so routing doesn't depend on which alias reaches the publisher.sftp.makedirs(..., exist_ok=True)before upload.Not touched
get_last_post_IDalready routes topostshowcorrectly — the split was only on the upload side.