Skip to content

Add showConsoleDebug option#197

Open
Liooo wants to merge 2 commits into
kamilkp:masterfrom
Liooo:show-console-debug-option
Open

Add showConsoleDebug option#197
Liooo wants to merge 2 commits into
kamilkp:masterfrom
Liooo:show-console-debug-option

Conversation

@Liooo

@Liooo Liooo commented Mar 28, 2018

Copy link
Copy Markdown
Contributor

The console warning shown here is usually very useful, but sometimes we want to suppress it (like in production).

This PR:

  • adds showConsoleDebug option, which hides the console warnings when set to false (defaults to true, so this is backward compatible)
  • bumps up the version to 2.1.0

Liooo added 2 commits April 3, 2018 19:07
added showConsoleDebug option
@Liooo Liooo force-pushed the show-console-debug-option branch from 8e5b980 to b75ff1b Compare April 3, 2018 10:39
@Liooo

Liooo commented Apr 3, 2018

Copy link
Copy Markdown
Contributor Author

@kamilkp resolved conflict, plz merge if it's looking good

@mistic100

mistic100 commented May 24, 2018

Copy link
Copy Markdown

@kamilkp please merge this feature. In my list I have merged top/bottom borders generating a 1px difference between the actual size and the computed size. This is not problem and should not spam the console. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants