chore: use common function for backend http requests#787
Open
mcdurdin wants to merge 1 commit into
Open
Conversation
User Test ResultsTest specification and instructions User tests are not required |
Establish Util::call_api_keyman_com and Util::call_downloads_keyman_com as common functions for making http requests to these servers. Use curl instead of file_get_contents as it is more reliable and we have more control over parameters. The pattern for now could stand to be refactored further in the future to provide API functions for each endpoint and reduce repetition and fragility. Test-bot: skip
mcdurdin
force-pushed
the
chore/use-common-function-for-http-requests
branch
from
0b9e537 to
ece6d4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Establish Util::call_api_keyman_com and Util::call_downloads_keyman_com as common functions for making http requests to these servers. Use curl instead of file_get_contents as it is more reliable and we have more control over parameters.
The pattern for now could stand to be refactored further in the future to provide API functions for each endpoint and reduce repetition and fragility.
Test-bot: skip